Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-22 Thread Peter Foley
On Wed, Oct 22, 2014 at 4:03 AM, Richard Cochran wrote: > In the mean time, I would like to restore the testptp.mk that *does* > cross compile, so that people may use the test program if they > want. In fact I use this all the time, and so I am a bit annoyed that > something working was deleted

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-22 Thread Richard Cochran
On Tue, Oct 21, 2014 at 06:04:51PM -0400, Peter Foley wrote: > The intention of these changes was to generate more compiliation > coverage for code in Documentation/ Sounds good. > The underlying issue is that this doesn't work for cross-compiling > because kbuild doesn't have cross-compile

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-22 Thread Richard Cochran
On Tue, Oct 21, 2014 at 06:04:51PM -0400, Peter Foley wrote: The intention of these changes was to generate more compiliation coverage for code in Documentation/ Sounds good. The underlying issue is that this doesn't work for cross-compiling because kbuild doesn't have cross-compile support

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-22 Thread Peter Foley
On Wed, Oct 22, 2014 at 4:03 AM, Richard Cochran richardcoch...@gmail.com wrote: In the mean time, I would like to restore the testptp.mk that *does* cross compile, so that people may use the test program if they want. In fact I use this all the time, and so I am a bit annoyed that something

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Peter Foley
On Tue, Oct 21, 2014 at 2:27 PM, Richard Cochran wrote: > On Tue, Oct 21, 2014 at 09:58:51AM -0700, David Daney wrote: >> What I don't understand is why we are using hostprogs in this >> Makefile. Isn't this a program that would run on the target, not >> the build host? > > Yes. > > Peter, could

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
(adding Makefile author Peter Foley onto CC) On Tue, Oct 21, 2014 at 09:58:51AM -0700, David Daney wrote: > On 10/21/2014 09:35 AM, David Miller wrote: > >From: Richard Cochran > >Date: Tue, 21 Oct 2014 13:07:25 +0200 > > > >>On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: >

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread David Daney
On 10/21/2014 09:35 AM, David Miller wrote: From: Richard Cochran Date: Tue, 21 Oct 2014 13:07:25 +0200 On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index 293d6c09a11f..397c1cd2eda7 100644 ---

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread David Miller
From: Richard Cochran Date: Tue, 21 Oct 2014 13:07:25 +0200 > On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: >> diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile >> index 293d6c09a11f..397c1cd2eda7 100644 >> --- a/Documentation/ptp/Makefile >> +++

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
On Tue, Oct 21, 2014 at 02:03:45PM +0100, Markos Chandras wrote: > > Hmm I can't see this testptp.mk file in the mainline. What tree are you > referring to? Sorry, I have net-next open in front of me. The same guy who added the buggy Makefile deleted my working makefile... Thanks, Richard -- To

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Markos Chandras
On 10/21/2014 01:52 PM, Richard Cochran wrote: > (adding Peter Foley to CC ...) > > On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote: >> On 10/21/2014 12:07 PM, Richard Cochran wrote: >>> On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
(adding Peter Foley to CC ...) On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote: > On 10/21/2014 12:07 PM, Richard Cochran wrote: > > On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: > >> diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile > >>

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Markos Chandras
On 10/21/2014 12:07 PM, Richard Cochran wrote: > On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: >> diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile >> index 293d6c09a11f..397c1cd2eda7 100644 >> --- a/Documentation/ptp/Makefile >> +++

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: > diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile > index 293d6c09a11f..397c1cd2eda7 100644 > --- a/Documentation/ptp/Makefile > +++ b/Documentation/ptp/Makefile > @@ -1,5 +1,15 @@ > # List of programs to build

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index 293d6c09a11f..397c1cd2eda7 100644 --- a/Documentation/ptp/Makefile +++ b/Documentation/ptp/Makefile @@ -1,5 +1,15 @@ # List of programs to build

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Markos Chandras
On 10/21/2014 12:07 PM, Richard Cochran wrote: On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index 293d6c09a11f..397c1cd2eda7 100644 --- a/Documentation/ptp/Makefile +++ b/Documentation/ptp/Makefile @@

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
(adding Peter Foley to CC ...) On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote: On 10/21/2014 12:07 PM, Richard Cochran wrote: On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Markos Chandras
On 10/21/2014 01:52 PM, Richard Cochran wrote: (adding Peter Foley to CC ...) On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote: On 10/21/2014 12:07 PM, Richard Cochran wrote: On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
On Tue, Oct 21, 2014 at 02:03:45PM +0100, Markos Chandras wrote: Hmm I can't see this testptp.mk file in the mainline. What tree are you referring to? Sorry, I have net-next open in front of me. The same guy who added the buggy Makefile deleted my working makefile... Thanks, Richard -- To

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread David Miller
From: Richard Cochran richardcoch...@gmail.com Date: Tue, 21 Oct 2014 13:07:25 +0200 On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index 293d6c09a11f..397c1cd2eda7 100644 --- a/Documentation/ptp/Makefile

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread David Daney
On 10/21/2014 09:35 AM, David Miller wrote: From: Richard Cochran richardcoch...@gmail.com Date: Tue, 21 Oct 2014 13:07:25 +0200 On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Richard Cochran
(adding Makefile author Peter Foley onto CC) On Tue, Oct 21, 2014 at 09:58:51AM -0700, David Daney wrote: On 10/21/2014 09:35 AM, David Miller wrote: From: Richard Cochran richardcoch...@gmail.com Date: Tue, 21 Oct 2014 13:07:25 +0200 On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Peter Foley
On Tue, Oct 21, 2014 at 2:27 PM, Richard Cochran richardcoch...@gmail.com wrote: On Tue, Oct 21, 2014 at 09:58:51AM -0700, David Daney wrote: What I don't understand is why we are using hostprogs in this Makefile. Isn't this a program that would run on the target, not the build host? Yes.

[PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-20 Thread Markos Chandras
The MIPS system calls are defined based on the -mabi gcc option. However, the testptp is built on the host using the unistd header from the kernel sources which were built for the MIPS architecture thus guarded with the __MIPS_SIM_{ABI64, ABI32, NABI32} definitions leading to the following build

[PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-20 Thread Markos Chandras
The MIPS system calls are defined based on the -mabi gcc option. However, the testptp is built on the host using the unistd header from the kernel sources which were built for the MIPS architecture thus guarded with the __MIPS_SIM_{ABI64, ABI32, NABI32} definitions leading to the following build