Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-09 Thread Nathan Chancellor
On Wed, Mar 10, 2021 at 02:09:02AM +0900, Masahiro Yamada wrote: > On Thu, Mar 4, 2021 at 12:34 PM Masahiro Yamada wrote: > > > > On Thu, Mar 4, 2021 at 9:18 AM Bernhard Rosenkränzer wrote: > > > > > > If LLD was built with -DLLD_VENDOR="xyz", ld.lld --version output > > > will prefix

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-09 Thread Masahiro Yamada
On Thu, Mar 4, 2021 at 12:34 PM Masahiro Yamada wrote: > > On Thu, Mar 4, 2021 at 9:18 AM Bernhard Rosenkränzer wrote: > > > > If LLD was built with -DLLD_VENDOR="xyz", ld.lld --version output > > will prefix LLD_VENDOR. Since LLD_VENDOR can contain spaces, the > > LLD identifier isn't

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-03 Thread Masahiro Yamada
On Thu, Mar 4, 2021 at 9:18 AM Bernhard Rosenkränzer wrote: > > If LLD was built with -DLLD_VENDOR="xyz", ld.lld --version output > will prefix LLD_VENDOR. Since LLD_VENDOR can contain spaces, the > LLD identifier isn't guaranteed to be $2 either. > > Adjust the version checker to handle such

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-03 Thread Nathan Chancellor
On Wed, Mar 03, 2021 at 08:38:06PM +0900, Masahiro Yamada wrote: > On Wed, Mar 3, 2021 at 1:02 PM Nathan Chancellor wrote: > > > > Hi Bernhard, > > > > I have added the ClangBuiltLinux mailing list, kbuild mailing list, and > > Masahiro and Nick to CC. Maybe ld-version.sh and cc-version.sh should

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-03 Thread Masahiro Yamada
On Wed, Mar 3, 2021 at 1:02 PM Nathan Chancellor wrote: > > Hi Bernhard, > > I have added the ClangBuiltLinux mailing list, kbuild mailing list, and > Masahiro and Nick to CC. Maybe ld-version.sh and cc-version.sh should be > added to a MAINTAINERS entry to make sure we get CC'd (I can send one >

Re: [PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-03 Thread Nathan Chancellor
Hi Bernhard, I have added the ClangBuiltLinux mailing list, kbuild mailing list, and Masahiro and Nick to CC. Maybe ld-version.sh and cc-version.sh should be added to a MAINTAINERS entry to make sure we get CC'd (I can send one along tomorrow). On Tue, Mar 02, 2021 at 11:12:11PM +0100, Bernhard

[PATCH] Fix ld-version.sh script if LLD was built with LLD_VENDOR

2021-03-02 Thread Bernhard Rosenkränzer
If LLD was built with -DLLD_VENDOR="xyz", ld.lld --version output will prefix LLD_VENDOR. Since LLD_VENDOR can contain spaces, the LLD identifier isn't guaranteed to be $2 either. Adjust the version checker to handle such versions of lld. Signed-off-by: Bernhard Rosenkränzer ---