Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread James Wang
On 06/08/2017 01:06 PM, Mike Galbraith wrote: > On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: >> This condition check was exist at before commit b5dd2f6047ca ("block: loop: >> improve performance via blk-mq") When add MQ support to loop device, it be >> removed because the member of

Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread James Wang
On 06/08/2017 01:06 PM, Mike Galbraith wrote: > On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: >> This condition check was exist at before commit b5dd2f6047ca ("block: loop: >> improve performance via blk-mq") When add MQ support to loop device, it be >> removed because the member of

Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread Mike Galbraith
On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread Mike Galbraith
On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread Ming Lei
On Thu, Jun 08, 2017 at 10:17:34AM +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread Ming Lei
On Thu, Jun 08, 2017 at 10:17:34AM +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

[PATCH] Fix loop device flush before configure v2

2017-06-07 Thread James Wang
This condition check was exist at before commit b5dd2f6047ca ("block: loop: improve performance via blk-mq") When add MQ support to loop device, it be removed because the member of '->lo_thread' be removed. And then upstream add '->worker_task', I think they forget add it to here. When I install

[PATCH] Fix loop device flush before configure v2

2017-06-07 Thread James Wang
This condition check was exist at before commit b5dd2f6047ca ("block: loop: improve performance via blk-mq") When add MQ support to loop device, it be removed because the member of '->lo_thread' be removed. And then upstream add '->worker_task', I think they forget add it to here. When I install