Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c
On 11/9/18 5:40 PM, Darrick J. Wong wrote: > On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote: > > Sorry, but all submissions must have a Signed-off-by: to be reviewed. > > Also, there's no To: header on this message?? Also, it's not the only misspelling, and not even the only instance of "auxillary" in the xfs codebase ... generally we only fix up such things when we're touching surrounding code for a more substantive change. -Eric > NAK. > > --D > >> --- >> fs/xfs/kmem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c >> index fdd9d6ede25c..73ec1f84e591 100644 >> --- a/fs/xfs/kmem.c >> +++ b/fs/xfs/kmem.c >> @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags) >> return ptr; >> >> /* >> - * __vmalloc() will allocate data pages and auxillary structures (e.g. >> + * __vmalloc() will allocate data pages and auxiliary structures (e.g. >> * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context >> * here. Hence we need to tell memory reclaim that we are in such a >> * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering >> -- >> 2.17.1 >> >
Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c
On 11/9/18 5:40 PM, Darrick J. Wong wrote: > On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote: > > Sorry, but all submissions must have a Signed-off-by: to be reviewed. > > Also, there's no To: header on this message?? Also, it's not the only misspelling, and not even the only instance of "auxillary" in the xfs codebase ... generally we only fix up such things when we're touching surrounding code for a more substantive change. -Eric > NAK. > > --D > >> --- >> fs/xfs/kmem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c >> index fdd9d6ede25c..73ec1f84e591 100644 >> --- a/fs/xfs/kmem.c >> +++ b/fs/xfs/kmem.c >> @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags) >> return ptr; >> >> /* >> - * __vmalloc() will allocate data pages and auxillary structures (e.g. >> + * __vmalloc() will allocate data pages and auxiliary structures (e.g. >> * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context >> * here. Hence we need to tell memory reclaim that we are in such a >> * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering >> -- >> 2.17.1 >> >
Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c
On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote: Sorry, but all submissions must have a Signed-off-by: to be reviewed. Also, there's no To: header on this message?? NAK. --D > --- > fs/xfs/kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c > index fdd9d6ede25c..73ec1f84e591 100644 > --- a/fs/xfs/kmem.c > +++ b/fs/xfs/kmem.c > @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags) > return ptr; > > /* > - * __vmalloc() will allocate data pages and auxillary structures (e.g. > + * __vmalloc() will allocate data pages and auxiliary structures (e.g. >* pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context >* here. Hence we need to tell memory reclaim that we are in such a >* context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering > -- > 2.17.1 >
Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c
On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote: Sorry, but all submissions must have a Signed-off-by: to be reviewed. Also, there's no To: header on this message?? NAK. --D > --- > fs/xfs/kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c > index fdd9d6ede25c..73ec1f84e591 100644 > --- a/fs/xfs/kmem.c > +++ b/fs/xfs/kmem.c > @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags) > return ptr; > > /* > - * __vmalloc() will allocate data pages and auxillary structures (e.g. > + * __vmalloc() will allocate data pages and auxiliary structures (e.g. >* pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context >* here. Hence we need to tell memory reclaim that we are in such a >* context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering > -- > 2.17.1 >
[PATCH] Fix misspelling issue in fs/xfs/kmem.c
--- fs/xfs/kmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c index fdd9d6ede25c..73ec1f84e591 100644 --- a/fs/xfs/kmem.c +++ b/fs/xfs/kmem.c @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags) return ptr; /* -* __vmalloc() will allocate data pages and auxillary structures (e.g. +* __vmalloc() will allocate data pages and auxiliary structures (e.g. * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context * here. Hence we need to tell memory reclaim that we are in such a * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering -- 2.17.1
[PATCH] Fix misspelling issue in fs/xfs/kmem.c
--- fs/xfs/kmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c index fdd9d6ede25c..73ec1f84e591 100644 --- a/fs/xfs/kmem.c +++ b/fs/xfs/kmem.c @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags) return ptr; /* -* __vmalloc() will allocate data pages and auxillary structures (e.g. +* __vmalloc() will allocate data pages and auxiliary structures (e.g. * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context * here. Hence we need to tell memory reclaim that we are in such a * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering -- 2.17.1
