Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
Alexey Zaytsev wrote:
[resent with lkml added to cc, sorry]
Hello, gentlemen.
Theese two patches fix a problem instroduced in Linux 2.6.24, and
still present in the current Linus' 2.6.25 tree.
The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
driver is enabled. This happens because the b44 driver
needlessly enables the b43_pci_bridge code, which claims
the same pci ids as the bcm43xx driver. The b43_pci_bridge
code is needed for the b43{legacy} drivers, but for the
b44, only the "ssb pci core" is needed.
The first patch separates the ssb b43 pci bridge and the ssb pci
core config options and enables only the needed ones.
A similar patch was once sent to Michael Buesch, but he rejected
it, fearing that changing the config autoselects cold introduce
some unexpected bugs.
If you are intrested, a rather emotional thread may be found
e.g. here:
http://thread.gmane.org/gmane.linux.kernel/644266
That said, I believe the patch may introduce no more bugs,
but fixes a critical regression, which left some users
without a working wifi driver on the 2.6.24 kernel.
If you doubt its correctness, I may write a longer description
on the changes introduced, but I hope they should be obvoius.
This patch is againts the current Linus' tree. I'd like it
to be added to both 2.6.25 and the 2.6.24-stable trees.
The second patch disables the bcm43xx driver if it can't
work due to the b43/b43legacy drivers inclusion, so no
users should be confused.
I have reviewed the above patches and tested them with what I believe to be most combinations.
Everything worked and corrected the unintended consequence of breaking bcm43xx when b44 is included.
I agree that these patches belong in 2.6.25 and stable (2.6.24). Of course, the problem goes away in
2.6.26.
ACKED-by: [EMAIL PROTECTED]
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
Alexey Zaytsev wrote:
[resent with lkml added to cc, sorry]
Hello, gentlemen.
Theese two patches fix a problem instroduced in Linux 2.6.24, and
still present in the current Linus' 2.6.25 tree.
The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
driver is enabled. This happens because the b44 driver
needlessly enables the b43_pci_bridge code, which claims
the same pci ids as the bcm43xx driver. The b43_pci_bridge
code is needed for the b43{legacy} drivers, but for the
b44, only the ssb pci core is needed.
The first patch separates the ssb b43 pci bridge and the ssb pci
core config options and enables only the needed ones.
A similar patch was once sent to Michael Buesch, but he rejected
it, fearing that changing the config autoselects cold introduce
some unexpected bugs.
If you are intrested, a rather emotional thread may be found
e.g. here:
http://thread.gmane.org/gmane.linux.kernel/644266
That said, I believe the patch may introduce no more bugs,
but fixes a critical regression, which left some users
without a working wifi driver on the 2.6.24 kernel.
If you doubt its correctness, I may write a longer description
on the changes introduced, but I hope they should be obvoius.
This patch is againts the current Linus' tree. I'd like it
to be added to both 2.6.25 and the 2.6.24-stable trees.
The second patch disables the bcm43xx driver if it can't
work due to the b43/b43legacy drivers inclusion, so no
users should be confused.
I have reviewed the above patches and tested them with what I believe to be most combinations.
Everything worked and corrected the unintended consequence of breaking bcm43xx when b44 is included.
I agree that these patches belong in 2.6.25 and stable (2.6.24). Of course, the problem goes away in
2.6.26.
ACKED-by: [EMAIL PROTECTED]
Larry
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
On Sat, Feb 23, 2008 at 7:20 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote: > > diff --git a/drivers/net/wireless/bcm43xx/Kconfig > b/drivers/net/wireless/bcm43xx/Kconfig > > index 0159701..afb8f43 100644 > > --- a/drivers/net/wireless/bcm43xx/Kconfig > > +++ b/drivers/net/wireless/bcm43xx/Kconfig > > @@ -1,6 +1,6 @@ > > config BCM43XX > > tristate "Broadcom BCM43xx wireless support (DEPRECATED)" > > - depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && > EXPERIMENTAL > > + depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && > (!SSB_B43_PCI_BRIDGE || SSB != y) && EXPERIMENTAL > > so if SSB is m it will break module auto-loading, right? > Right. If ssb == m, you can at least unload the ssb module manually, or specify the right module to load. In the first patch I sent to you, it was "!SSB_B43_PCI_BRIDGE" instead of "(!SSB_B43_PCI_BRIDGE || SSB != y)", but I thought that there is no reason to completely hide the bcm43xx option if ssb is compiled as module. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote: > diff --git a/drivers/net/wireless/bcm43xx/Kconfig > b/drivers/net/wireless/bcm43xx/Kconfig > index 0159701..afb8f43 100644 > --- a/drivers/net/wireless/bcm43xx/Kconfig > +++ b/drivers/net/wireless/bcm43xx/Kconfig > @@ -1,6 +1,6 @@ > config BCM43XX > tristate "Broadcom BCM43xx wireless support (DEPRECATED)" > - depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && > EXPERIMENTAL > + depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && > (!SSB_B43_PCI_BRIDGE || SSB != y) && EXPERIMENTAL so if SSB is m it will break module auto-loading, right? -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
[resent with lkml added to cc, sorry]
Hello, gentlemen.
Theese two patches fix a problem instroduced in Linux 2.6.24, and
still present in the current Linus' 2.6.25 tree.
The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
driver is enabled. This happens because the b44 driver
needlessly enables the b43_pci_bridge code, which claims
the same pci ids as the bcm43xx driver. The b43_pci_bridge
code is needed for the b43{legacy} drivers, but for the
b44, only the "ssb pci core" is needed.
The first patch separates the ssb b43 pci bridge and the ssb pci
core config options and enables only the needed ones.
A similar patch was once sent to Michael Buesch, but he rejected
it, fearing that changing the config autoselects cold introduce
some unexpected bugs.
If you are intrested, a rather emotional thread may be found
e.g. here:
http://thread.gmane.org/gmane.linux.kernel/644266
That said, I believe the patch may introduce no more bugs,
but fixes a critical regression, which left some users
without a working wifi driver on the 2.6.24 kernel.
If you doubt its correctness, I may write a longer description
on the changes introduced, but I hope they should be obvoius.
This patch is againts the current Linus' tree. I'd like it
to be added to both 2.6.25 and the 2.6.24-stable trees.
The second patch disables the bcm43xx driver if it can't
work due to the b43/b43legacy drivers inclusion, so no
users should be confused.
PS:
Sorry, I'm a bit tierd of trying to get git-send-patch to work
with the gmail smtp server, so the patches were went with
the thunderbird. If they end up being correpted, I've added
them as attachments.
-
From: Alexey Zaytsev <[EMAIL PROTECTED]>
Date: Sat, 23 Feb 2008 12:59:26 +0300
Subject: [PATCH] Use a separate config option for the b43 pci to ssb bridge.
The bridge code was unnecessary enabled by the b44
driver, but it prevents the bcm43xx driver from
being loaded, as the bridge claims the same pci ids.
Now we enable the birdge only if the b43{legacy}
drivers are selected.
Signed-off-by: Alexey Zaytsev <[EMAIL PROTECTED]>
---
drivers/net/wireless/b43/Kconfig |1 +
drivers/net/wireless/b43legacy/Kconfig |1 +
drivers/ssb/Kconfig|5 +
drivers/ssb/Makefile |2 +-
drivers/ssb/ssb_private.h |4 ++--
5 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/b43/Kconfig b/drivers/net/wireless/b43/Kconfig
index 1a2141d..8bc4bc4 100644
--- a/drivers/net/wireless/b43/Kconfig
+++ b/drivers/net/wireless/b43/Kconfig
@@ -32,6 +32,7 @@ config B43_PCI_AUTOSELECT
bool
depends on B43 && SSB_PCIHOST_POSSIBLE
select SSB_PCIHOST
+ select SSB_B43_PCI_BRIDGE
default y
# Auto-select SSB PCICORE driver, if possible
diff --git a/drivers/net/wireless/b43legacy/Kconfig
b/drivers/net/wireless/b43legacy/Kconfig
index 6745579..13c65fa 100644
--- a/drivers/net/wireless/b43legacy/Kconfig
+++ b/drivers/net/wireless/b43legacy/Kconfig
@@ -25,6 +25,7 @@ config B43LEGACY_PCI_AUTOSELECT
bool
depends on B43LEGACY && SSB_PCIHOST_POSSIBLE
select SSB_PCIHOST
+ select SSB_B43_PCI_BRIDGE
default y
# Auto-select SSB PCICORE driver, if possible
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index d976660..6f627f3 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -35,6 +35,11 @@ config SSB_PCIHOST
If unsure, say Y
+config SSB_B43_PCI_BRIDGE
+ bool
+ depends on SSB_PCIHOST
+ default n
+
config SSB_PCMCIAHOST_POSSIBLE
bool
depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
diff --git a/drivers/ssb/Makefile b/drivers/ssb/Makefile
index 7be3975..1bf35f0 100644
--- a/drivers/ssb/Makefile
+++ b/drivers/ssb/Makefile
@@ -13,6 +13,6 @@ ssb-$(CONFIG_SSB_DRIVER_PCICORE) += driver_pcicore.o
# b43 pci-ssb-bridge driver
# Not strictly a part of SSB, but kept here for convenience
-ssb-$(CONFIG_SSB_PCIHOST) += b43_pci_bridge.o
+ssb-$(CONFIG_SSB_B43_PCI_BRIDGE) += b43_pci_bridge.o
obj-$(CONFIG_SSB) += ssb.o
diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
index a789364..21eca2b 100644
--- a/drivers/ssb/ssb_private.h
+++ b/drivers/ssb/ssb_private.h
@@ -120,10 +120,10 @@ extern int ssb_devices_thaw(struct ssb_bus *bus);
extern struct ssb_bus *ssb_pci_dev_to_bus(struct pci_dev *pdev);
/* b43_pci_bridge.c */
-#ifdef CONFIG_SSB_PCIHOST
+#ifdef CONFIG_SSB_B43_PCI_BRIDGE
extern int __init b43_pci_ssb_bridge_init(void);
extern void __exit b43_pci_ssb_bridge_exit(void);
-#else /* CONFIG_SSB_PCIHOST */
+#else /* CONFIG_SSB_B43_PCI_BRIDGR */
static inline int b43_pci_ssb_bridge_init(void)
{
return 0;
--
1.5.2.GIT
From: Alexey Zaytsev <[EMAIL PROTECTED]>
Date: Sat, 23 Feb 2008 13:33:07 +0300
Subject: [PATCH] Don't build the bcm43xx driver if SSB is static and the b43
PCI-SSB
[PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
[resent with lkml added to cc, sorry]
Hello, gentlemen.
Theese two patches fix a problem instroduced in Linux 2.6.24, and
still present in the current Linus' 2.6.25 tree.
The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
driver is enabled. This happens because the b44 driver
needlessly enables the b43_pci_bridge code, which claims
the same pci ids as the bcm43xx driver. The b43_pci_bridge
code is needed for the b43{legacy} drivers, but for the
b44, only the ssb pci core is needed.
The first patch separates the ssb b43 pci bridge and the ssb pci
core config options and enables only the needed ones.
A similar patch was once sent to Michael Buesch, but he rejected
it, fearing that changing the config autoselects cold introduce
some unexpected bugs.
If you are intrested, a rather emotional thread may be found
e.g. here:
http://thread.gmane.org/gmane.linux.kernel/644266
That said, I believe the patch may introduce no more bugs,
but fixes a critical regression, which left some users
without a working wifi driver on the 2.6.24 kernel.
If you doubt its correctness, I may write a longer description
on the changes introduced, but I hope they should be obvoius.
This patch is againts the current Linus' tree. I'd like it
to be added to both 2.6.25 and the 2.6.24-stable trees.
The second patch disables the bcm43xx driver if it can't
work due to the b43/b43legacy drivers inclusion, so no
users should be confused.
PS:
Sorry, I'm a bit tierd of trying to get git-send-patch to work
with the gmail smtp server, so the patches were went with
the thunderbird. If they end up being correpted, I've added
them as attachments.
-
From: Alexey Zaytsev [EMAIL PROTECTED]
Date: Sat, 23 Feb 2008 12:59:26 +0300
Subject: [PATCH] Use a separate config option for the b43 pci to ssb bridge.
The bridge code was unnecessary enabled by the b44
driver, but it prevents the bcm43xx driver from
being loaded, as the bridge claims the same pci ids.
Now we enable the birdge only if the b43{legacy}
drivers are selected.
Signed-off-by: Alexey Zaytsev [EMAIL PROTECTED]
---
drivers/net/wireless/b43/Kconfig |1 +
drivers/net/wireless/b43legacy/Kconfig |1 +
drivers/ssb/Kconfig|5 +
drivers/ssb/Makefile |2 +-
drivers/ssb/ssb_private.h |4 ++--
5 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/b43/Kconfig b/drivers/net/wireless/b43/Kconfig
index 1a2141d..8bc4bc4 100644
--- a/drivers/net/wireless/b43/Kconfig
+++ b/drivers/net/wireless/b43/Kconfig
@@ -32,6 +32,7 @@ config B43_PCI_AUTOSELECT
bool
depends on B43 SSB_PCIHOST_POSSIBLE
select SSB_PCIHOST
+ select SSB_B43_PCI_BRIDGE
default y
# Auto-select SSB PCICORE driver, if possible
diff --git a/drivers/net/wireless/b43legacy/Kconfig
b/drivers/net/wireless/b43legacy/Kconfig
index 6745579..13c65fa 100644
--- a/drivers/net/wireless/b43legacy/Kconfig
+++ b/drivers/net/wireless/b43legacy/Kconfig
@@ -25,6 +25,7 @@ config B43LEGACY_PCI_AUTOSELECT
bool
depends on B43LEGACY SSB_PCIHOST_POSSIBLE
select SSB_PCIHOST
+ select SSB_B43_PCI_BRIDGE
default y
# Auto-select SSB PCICORE driver, if possible
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index d976660..6f627f3 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -35,6 +35,11 @@ config SSB_PCIHOST
If unsure, say Y
+config SSB_B43_PCI_BRIDGE
+ bool
+ depends on SSB_PCIHOST
+ default n
+
config SSB_PCMCIAHOST_POSSIBLE
bool
depends on SSB (PCMCIA = y || PCMCIA = SSB) EXPERIMENTAL
diff --git a/drivers/ssb/Makefile b/drivers/ssb/Makefile
index 7be3975..1bf35f0 100644
--- a/drivers/ssb/Makefile
+++ b/drivers/ssb/Makefile
@@ -13,6 +13,6 @@ ssb-$(CONFIG_SSB_DRIVER_PCICORE) += driver_pcicore.o
# b43 pci-ssb-bridge driver
# Not strictly a part of SSB, but kept here for convenience
-ssb-$(CONFIG_SSB_PCIHOST) += b43_pci_bridge.o
+ssb-$(CONFIG_SSB_B43_PCI_BRIDGE) += b43_pci_bridge.o
obj-$(CONFIG_SSB) += ssb.o
diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
index a789364..21eca2b 100644
--- a/drivers/ssb/ssb_private.h
+++ b/drivers/ssb/ssb_private.h
@@ -120,10 +120,10 @@ extern int ssb_devices_thaw(struct ssb_bus *bus);
extern struct ssb_bus *ssb_pci_dev_to_bus(struct pci_dev *pdev);
/* b43_pci_bridge.c */
-#ifdef CONFIG_SSB_PCIHOST
+#ifdef CONFIG_SSB_B43_PCI_BRIDGE
extern int __init b43_pci_ssb_bridge_init(void);
extern void __exit b43_pci_ssb_bridge_exit(void);
-#else /* CONFIG_SSB_PCIHOST */
+#else /* CONFIG_SSB_B43_PCI_BRIDGR */
static inline int b43_pci_ssb_bridge_init(void)
{
return 0;
--
1.5.2.GIT
From: Alexey Zaytsev [EMAIL PROTECTED]
Date: Sat, 23 Feb 2008 13:33:07 +0300
Subject: [PATCH] Don't build the bcm43xx driver if SSB is static and the b43
PCI-SSB bridge code is
Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote: diff --git a/drivers/net/wireless/bcm43xx/Kconfig b/drivers/net/wireless/bcm43xx/Kconfig index 0159701..afb8f43 100644 --- a/drivers/net/wireless/bcm43xx/Kconfig +++ b/drivers/net/wireless/bcm43xx/Kconfig @@ -1,6 +1,6 @@ config BCM43XX tristate Broadcom BCM43xx wireless support (DEPRECATED) - depends on PCI IEEE80211 IEEE80211_SOFTMAC WLAN_80211 EXPERIMENTAL + depends on PCI IEEE80211 IEEE80211_SOFTMAC WLAN_80211 (!SSB_B43_PCI_BRIDGE || SSB != y) EXPERIMENTAL so if SSB is m it will break module auto-loading, right? -- Greetings Michael. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
On Sat, Feb 23, 2008 at 7:20 PM, Michael Buesch [EMAIL PROTECTED] wrote: On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote: diff --git a/drivers/net/wireless/bcm43xx/Kconfig b/drivers/net/wireless/bcm43xx/Kconfig index 0159701..afb8f43 100644 --- a/drivers/net/wireless/bcm43xx/Kconfig +++ b/drivers/net/wireless/bcm43xx/Kconfig @@ -1,6 +1,6 @@ config BCM43XX tristate Broadcom BCM43xx wireless support (DEPRECATED) - depends on PCI IEEE80211 IEEE80211_SOFTMAC WLAN_80211 EXPERIMENTAL + depends on PCI IEEE80211 IEEE80211_SOFTMAC WLAN_80211 (!SSB_B43_PCI_BRIDGE || SSB != y) EXPERIMENTAL so if SSB is m it will break module auto-loading, right? Right. If ssb == m, you can at least unload the ssb module manually, or specify the right module to load. In the first patch I sent to you, it was !SSB_B43_PCI_BRIDGE instead of (!SSB_B43_PCI_BRIDGE || SSB != y), but I thought that there is no reason to completely hide the bcm43xx option if ssb is compiled as module. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
