Re: [PATCH] Fix warning in gkc (make gconfig) {Scanned}

2005-03-12 Thread Andrew Morton 
Sam Ravnborg <[EMAIL PROTECTED]> wrote:
>
> On Wed, Mar 09, 2005 at 09:36:12AM +0100, Romain Lievin wrote:
> > Hi,
> > 
> > this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc
> > (the GTK Kernel Configurator).
> 
> Applied, 2 warnings fixed - 10 more to go.
> Care to take a look at them?
> Also gconfig does not support setting localversion - is this something you
> can fix too?
> 

fyi, gconfig doesn't display those cute little pixmap buttons any more. 
That bug was introduced by the patch "make gconfig work with gtk-2.4".

I'm planning on simply reverting that patch.  Which should motivate someone
to have another go at fixing it for gtk2.4.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Fix warning in gkc (make gconfig) {Scanned}

2005-03-12 Thread Sam Ravnborg 
On Wed, Mar 09, 2005 at 09:36:12AM +0100, Romain Lievin wrote:
> Hi,
> 
> this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc
> (the GTK Kernel Configurator).

Applied, 2 warnings fixed - 10 more to go.
Care to take a look at them?
Also gconfig does not support setting localversion - is this something you
can fix too?

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] Fix warning in gkc (make gconfig) {Scanned}

2005-03-09 Thread Romain Lievin 
Hi,

this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc
(the GTK Kernel Configurator).

Please apply.

Thanks, Romain.

Signed-off-by: Romain Liévin <[EMAIL PROTECTED]>
[cut here]
diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c 
linux/scripts/kconfig/gconf.c
--- linux-2.6.11-rc3/scripts/kconfig/gconf.c2005-02-11 20:41:34.0 
+0100
+++ linux/scripts/kconfig/gconf.c   2005-02-11 20:43:23.0 +0100
@@ -222,15 +222,15 @@
switch (view_mode) {
case SINGLE_VIEW:
widget = glade_xml_get_widget(xml, "button4");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
case SPLIT_VIEW:
widget = glade_xml_get_widget(xml, "button5");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
case FULL_VIEW:
widget = glade_xml_get_widget(xml, "button6");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
}
 
[cut here]
-- 
Romain Liévin : <[EMAIL PROTECTED]>
Web site :  http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"






-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] Fix warning in gkc (make gconfig) {Scanned}

2005-02-11 Thread Romain Lievin 
Hi,

this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc 
(the GTK Kernel Configurator).

Please apply.

Thanks, Romain.

Signed-off-by: Romain Liévin <[EMAIL PROTECTED]>
[cut here]
diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c 
linux/scripts/kconfig/gconf.c
--- linux-2.6.11-rc3/scripts/kconfig/gconf.c2005-02-11 20:41:34.0 
+0100
+++ linux/scripts/kconfig/gconf.c   2005-02-11 20:43:23.0 +0100
@@ -222,15 +222,15 @@
switch (view_mode) {
case SINGLE_VIEW:
widget = glade_xml_get_widget(xml, "button4");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
case SPLIT_VIEW:
widget = glade_xml_get_widget(xml, "button5");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
case FULL_VIEW:
widget = glade_xml_get_widget(xml, "button6");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
}
 
[cut here]
-- 
Romain Liévin : <[EMAIL PROTECTED]>
Web site :  http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"



diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c 
linux/scripts/kconfig/gconf.c
--- linux-2.6.11-rc3/scripts/kconfig/gconf.c2005-02-11 20:41:34.0 
+0100
+++ linux/scripts/kconfig/gconf.c   2005-02-11 20:43:23.0 +0100
@@ -222,15 +222,15 @@
switch (view_mode) {
case SINGLE_VIEW:
widget = glade_xml_get_widget(xml, "button4");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
case SPLIT_VIEW:
widget = glade_xml_get_widget(xml, "button5");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
case FULL_VIEW:
widget = glade_xml_get_widget(xml, "button6");
-   gtk_button_clicked(GTK_BUTTON(widget));
+   g_signal_emit_by_name(widget, "clicked");
break;
}