Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Fri, 8 Sep 2017, Benjamin Tissoires wrote: > I know I requested a v2, but meanwhile some users are experiencing > delays at resume: > https://bugzilla.kernel.org/show_bug.cgi?id=196851 > > Jiri, could you take this one in v4.14 (maybe with @stable) and we'll > figure out a way to fix this

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Fri, 8 Sep 2017, Benjamin Tissoires wrote: > I know I requested a v2, but meanwhile some users are experiencing > delays at resume: > https://bugzilla.kernel.org/show_bug.cgi?id=196851 > > Jiri, could you take this one in v4.14 (maybe with @stable) and we'll > figure out a way to fix this

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 24 2017 or thereabouts, Lyude Paul wrote: > On Mon, 2017-07-24 at 10:15 +0200, Benjamin Tissoires wrote: > > On Jul 22 2017 or thereabouts, Lyude wrote: > > > So it looks like that suspend/resume has actually always been > > > broken on > > > hid-rmi. The fact it worked was a rather silly

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 24 2017 or thereabouts, Lyude Paul wrote: > On Mon, 2017-07-24 at 10:15 +0200, Benjamin Tissoires wrote: > > On Jul 22 2017 or thereabouts, Lyude wrote: > > > So it looks like that suspend/resume has actually always been > > > broken on > > > hid-rmi. The fact it worked was a rather silly

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

Yeah I noticed that, sorry if my response wasn't very clear! Should probably wait to have my morning coffee before responding to these messages :P On Mon, 2017-07-24 at 21:28 +0200, Jiri Kosina wrote: > On Mon, 24 Jul 2017, Lyude Paul wrote: > > > > > So, call hid_hw_open() in rmi_post_resume()

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

Yeah I noticed that, sorry if my response wasn't very clear! Should probably wait to have my morning coffee before responding to these messages :P On Mon, 2017-07-24 at 21:28 +0200, Jiri Kosina wrote: > On Mon, 24 Jul 2017, Lyude Paul wrote: > > > > > So, call hid_hw_open() in rmi_post_resume()

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Mon, 24 Jul 2017, Lyude Paul wrote: > > > So, call hid_hw_open() in rmi_post_resume() so we make sure that > > > the > > > device is alive before we try talking to it. > > > > > > This fixes RMI device suspend/resume over HID. > > > - int ret; > > > + int ret = 0; > > > > What's

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Mon, 24 Jul 2017, Lyude Paul wrote: > > > So, call hid_hw_open() in rmi_post_resume() so we make sure that > > > the > > > device is alive before we try talking to it. > > > > > > This fixes RMI device suspend/resume over HID. > > > - int ret; > > > + int ret = 0; > > > > What's

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Mon, 2017-07-24 at 10:15 +0200, Benjamin Tissoires wrote: > On Jul 22 2017 or thereabouts, Lyude wrote: > > So it looks like that suspend/resume has actually always been > > broken on > > hid-rmi. The fact it worked was a rather silly coincidence that was > > relying on the HID device to

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Mon, 2017-07-24 at 10:15 +0200, Benjamin Tissoires wrote: > On Jul 22 2017 or thereabouts, Lyude wrote: > > So it looks like that suspend/resume has actually always been > > broken on > > hid-rmi. The fact it worked was a rather silly coincidence that was > > relying on the HID device to

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Sun, 2017-07-23 at 12:54 +0300, Andy Shevchenko wrote: > On Sun, Jul 23, 2017 at 4:15 AM, Lyude wrote: > > > So, call hid_hw_open() in rmi_post_resume() so we make sure that > > the > > device is alive before we try talking to it. > > > > This fixes RMI device

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Sun, 2017-07-23 at 12:54 +0300, Andy Shevchenko wrote: > On Sun, Jul 23, 2017 at 4:15 AM, Lyude wrote: > > > So, call hid_hw_open() in rmi_post_resume() so we make sure that > > the > > device is alive before we try talking to it. > > > > This fixes RMI device suspend/resume over HID. > > -

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 22 2017 or thereabouts, Lyude wrote: > So it looks like that suspend/resume has actually always been broken on > hid-rmi. The fact it worked was a rather silly coincidence that was > relying on the HID device to already be opened upon resume. This means > that so long as anything was

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Jul 22 2017 or thereabouts, Lyude wrote: > So it looks like that suspend/resume has actually always been broken on > hid-rmi. The fact it worked was a rather silly coincidence that was > relying on the HID device to already be opened upon resume. This means > that so long as anything was

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Sun, Jul 23, 2017 at 4:15 AM, Lyude wrote: > So, call hid_hw_open() in rmi_post_resume() so we make sure that the > device is alive before we try talking to it. > > This fixes RMI device suspend/resume over HID. > - int ret; > + int ret = 0; What's the point?

Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

On Sun, Jul 23, 2017 at 4:15 AM, Lyude wrote: > So, call hid_hw_open() in rmi_post_resume() so we make sure that the > device is alive before we try talking to it. > > This fixes RMI device suspend/resume over HID. > - int ret; > + int ret = 0; What's the point? > > if

[PATCH] HID: rmi: Make sure the HID device is opened on resume

So it looks like that suspend/resume has actually always been broken on hid-rmi. The fact it worked was a rather silly coincidence that was relying on the HID device to already be opened upon resume. This means that so long as anything was reading the /dev/input/eventX node for for an RMI device,

[PATCH] HID: rmi: Make sure the HID device is opened on resume

So it looks like that suspend/resume has actually always been broken on hid-rmi. The fact it worked was a rather silly coincidence that was relying on the HID device to already be opened upon resume. This means that so long as anything was reading the /dev/input/eventX node for for an RMI device,