Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Leon Romanovsky
On Tue, Nov 07, 2017 at 08:30:22AM -0600, Gustavo A. R. Silva wrote: > Hi Leon, > > Quoting Leon Romanovsky : > > > On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. > > > > > >

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Leon Romanovsky
On Tue, Nov 07, 2017 at 08:30:22AM -0600, Gustavo A. R. Silva wrote: > Hi Leon, > > Quoting Leon Romanovsky : > > > On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. > > > > > > Addresses-Coverity-ID: 1268780 >

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Gustavo A. R. Silva
Hi Leon, Quoting Leon Romanovsky : On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Gustavo A. R. Silva
Hi Leon, Quoting Leon Romanovsky : On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- 1

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Gustavo A. R. Silva
Hi Yuval, Quoting Yuval Shaia : On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 What's that? Coverity is a static code analyzer. I am fixing Coverity

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Gustavo A. R. Silva
Hi Yuval, Quoting Yuval Shaia : On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 What's that? Coverity is a static code analyzer. I am fixing Coverity issues and that is the

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Leon Romanovsky
On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > 1

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-07 Thread Leon Romanovsky
On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > 1 file changed, 1

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-06 Thread Yuval Shaia
On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 What's that? > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c |

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-06 Thread Yuval Shaia
On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 What's that? > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > 1 file

[PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-06 Thread Gustavo A. R. Silva
Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-06 Thread Gustavo A. R. Silva
Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c