Re: [PATCH] Initialise mmu_notifier_range correctly

On Thu, Jan 03, 2019 at 06:43:13AM -0800, Matthew Wilcox wrote: > On Thu, Jan 03, 2019 at 09:31:16AM -0500, Jerome Glisse wrote: > > On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote: > > > > > > One of the paths in follow_pte_pmd() initialised the mmu_notifier_range > > >

Re: [PATCH] Initialise mmu_notifier_range correctly

On Thu, Jan 03, 2019 at 06:39:08AM -0800, Matthew Wilcox wrote: > On Thu, Jan 03, 2019 at 09:29:59AM -0500, Jerome Glisse wrote: > > On Wed, Jan 02, 2019 at 08:18:33PM -0800, Matthew Wilcox wrote: > > > On Wed, Jan 02, 2019 at 07:32:08PM -0800, John Hubbard wrote: > > > > Having the range struct

Re: [PATCH] Initialise mmu_notifier_range correctly

On Thu, Jan 03, 2019 at 09:31:16AM -0500, Jerome Glisse wrote: > On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote: > > > > One of the paths in follow_pte_pmd() initialised the mmu_notifier_range > > incorrectly. > > > > Signed-off-by: Matthew Wilcox > > Fixes: ac46d4f3c432

Re: [PATCH] Initialise mmu_notifier_range correctly

On Thu, Jan 03, 2019 at 09:29:59AM -0500, Jerome Glisse wrote: > On Wed, Jan 02, 2019 at 08:18:33PM -0800, Matthew Wilcox wrote: > > On Wed, Jan 02, 2019 at 07:32:08PM -0800, John Hubbard wrote: > > > Having the range struct declared in separate places from the > > > mmu_notifier_range_init() > >

Re: [PATCH] Initialise mmu_notifier_range correctly

On Thu, Jan 03, 2019 at 09:31:16AM -0500, Jerome Glisse wrote: > On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote: > > > > One of the paths in follow_pte_pmd() initialised the mmu_notifier_range > > incorrectly. > > > > Signed-off-by: Matthew Wilcox > > Fixes: ac46d4f3c432

Re: [PATCH] Initialise mmu_notifier_range correctly

On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote: > > One of the paths in follow_pte_pmd() initialised the mmu_notifier_range > incorrectly. > > Signed-off-by: Matthew Wilcox > Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for > invalidate_range_start/end calls v2") >

Re: [PATCH] Initialise mmu_notifier_range correctly

On Wed, Jan 02, 2019 at 08:18:33PM -0800, Matthew Wilcox wrote: > On Wed, Jan 02, 2019 at 07:32:08PM -0800, John Hubbard wrote: > > Having the range struct declared in separate places from the > > mmu_notifier_range_init() > > calls is not great. But I'm not sure I see a way to make it

Re: [PATCH] Initialise mmu_notifier_range correctly

On Wed, Jan 02, 2019 at 07:32:08PM -0800, John Hubbard wrote: > Having the range struct declared in separate places from the > mmu_notifier_range_init() > calls is not great. But I'm not sure I see a way to make it significantly > cleaner, given > that __follow_pte_pmd uses the range pointer as

Re: [PATCH] Initialise mmu_notifier_range correctly

On 1/2/19 5:56 PM, Jerome Glisse wrote: > On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote: >> >> One of the paths in follow_pte_pmd() initialised the mmu_notifier_range >> incorrectly. >> >> Signed-off-by: Matthew Wilcox >> Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for

Re: [PATCH] Initialise mmu_notifier_range correctly

On Wed, Jan 02, 2019 at 04:21:26PM -0800, Matthew Wilcox wrote: > > One of the paths in follow_pte_pmd() initialised the mmu_notifier_range > incorrectly. > > Signed-off-by: Matthew Wilcox > Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for > invalidate_range_start/end calls v2") >

[PATCH] Initialise mmu_notifier_range correctly

One of the paths in follow_pte_pmd() initialised the mmu_notifier_range incorrectly. Signed-off-by: Matthew Wilcox Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for invalidate_range_start/end calls v2") Tested-by: Dave Chinner diff --git a/mm/memory.c b/mm/memory.c index