Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-04 Thread Dmitry Torokhov
On Sat, Jan 04, 2014 at 09:41:43AM -0800, Andrey Smirnov wrote: > > Anyway, TL;DR of the whole thing is: > - Your arguments do not convince me in the slightest > - I don't think that mine do you > - Let's stop wasting out time > - Do as you see fit, since you are the maintainer > Nah, I

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-04 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 11:46 PM, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 10:49:07PM -0800, Andrey Smirnov wrote: >> On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov >> wrote: >> > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: >> >> On Fri, Jan 3, 2014 at 9:28 PM,

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-04 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 11:46 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Jan 03, 2014 at 10:49:07PM -0800, Andrey Smirnov wrote: On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote:

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-04 Thread Dmitry Torokhov
On Sat, Jan 04, 2014 at 09:41:43AM -0800, Andrey Smirnov wrote: Anyway, TL;DR of the whole thing is: - Your arguments do not convince me in the slightest - I don't think that mine do you - Let's stop wasting out time - Do as you see fit, since you are the maintainer Nah, I think I'll

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 10:49:07PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov > wrote: > > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: > >> On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov > >> wrote: > >> >

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: >> On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov >> wrote: >> > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use >> > get_unaligned_le16 to access

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: > On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov > wrote: > > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use > > get_unaligned_le16 to access it. > > > > Also let's add build time check to make sure it

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov wrote: > pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use > get_unaligned_le16 to access it. > > Also let's add build time check to make sure it stays aligned. - AFAIK, there's no guarantee the "pcu" itself is aligned -

[PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
pcu->cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use get_unaligned_le16 to access it. Also let's add build time check to make sure it stays aligned. Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
pcu-cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use get_unaligned_le16 to access it. Also let's add build time check to make sure it stays aligned. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/misc/ims-pcu.c | 8 ++-- 1 file changed, 6

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: pcu-cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use get_unaligned_le16 to access it. Also let's add build time check to make sure it stays aligned. - AFAIK, there's no guarantee the pcu

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: pcu-cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need to use get_unaligned_le16 to access it. Also let's add build time check to

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Andrey Smirnov
On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: pcu-cmd_buf[IMS_PCU_DATA_OFFSET] is word aligned so we do not need

Re: [PATCH] Input: ims-pcu - remove unneeded get_unaligned_xxx

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 10:49:07PM -0800, Andrey Smirnov wrote: On Fri, Jan 3, 2014 at 10:16 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Jan 03, 2014 at 09:52:25PM -0800, Andrey Smirnov wrote: On Fri, Jan 3, 2014 at 9:28 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: