Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-12 Thread Quan Xu
On 2017/12/12 02:08, Jim Mattson wrote: Removing these two lines from the initialization of field_to_offset_table[] means that vmcs_field_to_offset() will return -ENOENT for IO_BITMAP_A or IO_BITMAP_B. Hence, handle_vmread and handle_vmwrite will incorrectly report these fields as unsupported V

Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-12 Thread Quan Xu
On 2017/12/09 00:18, David Hildenbrand wrote: On 08.12.2017 11:22, Quan Xu wrote: From: Quan Xu Since KVM removes the only I/O port 0x80 bypass on Intel hosts, clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING bit. Then these I/O permission bitmaps are not used at all, so dr

Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-11 Thread Jim Mattson
Removing these two lines from the initialization of field_to_offset_table[] means that vmcs_field_to_offset() will return -ENOENT for IO_BITMAP_A or IO_BITMAP_B. Hence, handle_vmread and handle_vmwrite will incorrectly report these fields as unsupported VMCS components if an L1 hypervisor tries to

Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-10 Thread Quan Xu
On 2017/12/09 01:31, Jim Mattson wrote: On Fri, Dec 8, 2017 at 2:22 AM, Quan Xu wrote: From: Quan Xu Since KVM removes the only I/O port 0x80 bypass on Intel hosts, clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING bit. Then these I/O permission bitmaps are not used at all,

Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-10 Thread Quan Xu
On 2017/12/09 00:18, David Hildenbrand wrote: On 08.12.2017 11:22, Quan Xu wrote: From: Quan Xu Since KVM removes the only I/O port 0x80 bypass on Intel hosts, clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING bit. Then these I/O permission bitmaps are not used at all, so dr

Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-08 Thread Jim Mattson
On Fri, Dec 8, 2017 at 2:22 AM, Quan Xu wrote: > From: Quan Xu > > Since KVM removes the only I/O port 0x80 bypass on Intel hosts, > clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING > bit. Then these I/O permission bitmaps are not used at all, so > drop I/O permission bitmaps. >

Re: [PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-08 Thread David Hildenbrand
On 08.12.2017 11:22, Quan Xu wrote: > From: Quan Xu > > Since KVM removes the only I/O port 0x80 bypass on Intel hosts, > clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING > bit. Then these I/O permission bitmaps are not used at all, so > drop I/O permission bitmaps. > > Signed-

[PATCH] KVM: VMX: drop I/O permission bitmaps

2017-12-08 Thread Quan Xu
From: Quan Xu Since KVM removes the only I/O port 0x80 bypass on Intel hosts, clear CPU_BASED_USE_IO_BITMAPS and set CPU_BASED_UNCOND_IO_EXITING bit. Then these I/O permission bitmaps are not used at all, so drop I/O permission bitmaps. Signed-off-by: Jim Mattson Signed-off-by: Radim Krčmář Si