Re: [PATCH] KVM: arm/arm64: prefer IS_ENABLED to a static variable

2015-03-11 Thread Christoffer Dall
On Thu, Mar 05, 2015 at 12:26:06PM +0100, Paolo Bonzini wrote: > IS_ENABLED gives compile-time checking and keeps the code clearer. > > The one exception is inside kvm_vm_ioctl_check_extension, where > the established idiom is to wrap the case labels with an #ifdef. > > Signed-off-by: Paolo

Re: [PATCH] KVM: arm/arm64: prefer IS_ENABLED to a static variable

2015-03-11 Thread Christoffer Dall
On Thu, Mar 05, 2015 at 12:26:06PM +0100, Paolo Bonzini wrote: IS_ENABLED gives compile-time checking and keeps the code clearer. The one exception is inside kvm_vm_ioctl_check_extension, where the established idiom is to wrap the case labels with an #ifdef. Signed-off-by: Paolo Bonzini

[PATCH] KVM: arm/arm64: prefer IS_ENABLED to a static variable

2015-03-05 Thread Paolo Bonzini
IS_ENABLED gives compile-time checking and keeps the code clearer. The one exception is inside kvm_vm_ioctl_check_extension, where the established idiom is to wrap the case labels with an #ifdef. Signed-off-by: Paolo Bonzini -- Untested... --- arch/arm/kvm/arm.c | 17 +

[PATCH] KVM: arm/arm64: prefer IS_ENABLED to a static variable

2015-03-05 Thread Paolo Bonzini
IS_ENABLED gives compile-time checking and keeps the code clearer. The one exception is inside kvm_vm_ioctl_check_extension, where the established idiom is to wrap the case labels with an #ifdef. Signed-off-by: Paolo Bonzini pbonz...@redhat.com -- Untested... --- arch/arm/kvm/arm.c | 17