Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-10 Thread Avi Kivity
Jeff Dike wrote: On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote: Some extra logic is needed on i386 with >= 4GB. Current code will wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not the answer since the processor will truncate it back to 32 bits (the return

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-10 Thread Avi Kivity
Jeff Dike wrote: On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote: Some extra logic is needed on i386 with = 4GB. Current code will wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not the answer since the processor will truncate it back to 32 bits (the return

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-08 Thread Jeff Dike
On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote: > Some extra logic is needed on i386 with >= 4GB. Current code will > wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not > the answer since the processor will truncate it back to 32 bits (the > return value is

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-08 Thread Jeff Dike
On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote: Some extra logic is needed on i386 with = 4GB. Current code will wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not the answer since the processor will truncate it back to 32 bits (the return value is eventually

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Avi Kivity
Jeff Dike wrote: > On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote: > >>> -static int rmode_tss_base(struct kvm* kvm) >>> +static unsigned long rmode_tss_base(struct kvm* kvm) >>> >> Should use gpa_t instead. >> > > Right you are, I didn't notice that type. > > Some

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Jeff Dike
On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote: > >-static int rmode_tss_base(struct kvm* kvm) > >+static unsigned long rmode_tss_base(struct kvm* kvm) > > Should use gpa_t instead. Right you are, I didn't notice that type. Will fix. Jeff -- Work

RE: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Li, Xin B
> >The long return value of rmode_tss_base is truncated by its declared >return type of int. > >Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> >-- > drivers/kvm/vmx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >Index: kvm/drivers/kvm/vmx.c

[PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Jeff Dike
The long return value of rmode_tss_base is truncated by its declared return type of int. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- drivers/kvm/vmx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: kvm/drivers/kvm/vmx.c

[PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Jeff Dike
The long return value of rmode_tss_base is truncated by its declared return type of int. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- drivers/kvm/vmx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: kvm/drivers/kvm/vmx.c

RE: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Li, Xin B
The long return value of rmode_tss_base is truncated by its declared return type of int. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- drivers/kvm/vmx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: kvm/drivers/kvm/vmx.c

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Jeff Dike
On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote: -static int rmode_tss_base(struct kvm* kvm) +static unsigned long rmode_tss_base(struct kvm* kvm) Should use gpa_t instead. Right you are, I didn't notice that type. Will fix. Jeff -- Work email -

Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Avi Kivity
Jeff Dike wrote: On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote: -static int rmode_tss_base(struct kvm* kvm) +static unsigned long rmode_tss_base(struct kvm* kvm) Should use gpa_t instead. Right you are, I didn't notice that type. Some extra logic is needed