Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-05 Thread Paulo Marques
Mathieu Desnoyers wrote: * Paulo Marques ([EMAIL PROTECTED]) wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. [...] From: Paulo Marques <[EMAIL PROTECTED]> Signed-off-by: Mathieu

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-05 Thread Rusty Russell
On Wednesday 05 December 2007 09:31:23 Mathieu Desnoyers wrote: > * Arjan van de Ven ([EMAIL PROTECTED]) wrote: > > On Tue, 04 Dec 2007 20:35:32 + > > > > Paulo Marques <[EMAIL PROTECTED]> wrote: > > > When resolving symbol names from addresses with aliased symbol names, > > > kallsyms_lookup

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-05 Thread Rusty Russell
On Wednesday 05 December 2007 09:31:23 Mathieu Desnoyers wrote: * Arjan van de Ven ([EMAIL PROTECTED]) wrote: On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-05 Thread Paulo Marques
Mathieu Desnoyers wrote: * Paulo Marques ([EMAIL PROTECTED]) wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. [...] From: Paulo Marques [EMAIL PROTECTED] Signed-off-by: Mathieu Desnoyers

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Tue, 04 Dec 2007 20:35:32 + Paulo Marques <[EMAIL PROTECTED]> wrote: > > > When resolving symbol names from addresses with aliased symbol names, > > kallsyms_lookup always returns the first symbol, even if it is a weak > > symbol. > > > >

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Andrew Morton
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques <[EMAIL PROTECTED]> wrote: > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Andrew Morton
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques <[EMAIL PROTECTED]> wrote: > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Rusty Russell
On Wednesday 05 December 2007 07:35:32 Paulo Marques wrote: > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. Thanks, this looks great. Rusty. -- To unsubscribe from this list: send the line

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Arjan van de Ven ([EMAIL PROTECTED]) wrote: > On Tue, 04 Dec 2007 20:35:32 + > Paulo Marques <[EMAIL PROTECTED]> wrote: > > > > > When resolving symbol names from addresses with aliased symbol names, > > kallsyms_lookup always returns the first symbol, even if it is a weak > > symbol. >

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Tue, 04 Dec 2007 20:35:32 + > Paulo Marques <[EMAIL PROTECTED]> wrote: > > > When resolving symbol names from addresses with aliased symbol names, > > kallsyms_lookup always returns the first symbol, even if it is a weak > > symbol. > > > >

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Arjan van de Ven
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques <[EMAIL PROTECTED]> wrote: > > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Andrew Morton
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques <[EMAIL PROTECTED]> wrote: > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Paulo Marques ([EMAIL PROTECTED]) wrote: > > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the weak symbols last > before feeding

[-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Paulo Marques
When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak symbols last before feeding them to the kernel. This way the kernel runtime isn't

[-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Paulo Marques
When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak symbols last before feeding them to the kernel. This way the kernel runtime isn't

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Andrew Morton
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Paulo Marques ([EMAIL PROTECTED]) wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak symbols last before feeding them to

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Arjan van de Ven
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Arjan van de Ven ([EMAIL PROTECTED]) wrote: On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Rusty Russell
On Wednesday 05 December 2007 07:35:32 Paulo Marques wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. Thanks, this looks great. Rusty. -- To unsubscribe from this list: send the line

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Andrew Morton
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Andrew Morton
On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch changes this by sorting the symbols with the weak

Re: [-mm PATCH] kallsyms should prefer non weak symbols

2007-12-04 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Tue, 04 Dec 2007 20:35:32 + Paulo Marques [EMAIL PROTECTED] wrote: When resolving symbol names from addresses with aliased symbol names, kallsyms_lookup always returns the first symbol, even if it is a weak symbol. This patch

Re: [PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-14 Thread Paulo Marques
Mathieu Desnoyers wrote: * Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: [...] kallsyms returns the first symbol encountered, even though it is weak, when it should in fact return sys_ni_syscall. Is it a concern for anyone else out there ? Would it make sense to fix it ? I don't know if it is a

Re: [PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-14 Thread Paulo Marques
Mathieu Desnoyers wrote: * Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: [...] kallsyms returns the first symbol encountered, even though it is weak, when it should in fact return sys_ni_syscall. Is it a concern for anyone else out there ? Would it make sense to fix it ? I don't know if it is a

[PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-13 Thread Mathieu Desnoyers
> [...] > kallsyms returns the first symbol encountered, even though it is weak, > when it should in fact return sys_ni_syscall. > Is it a concern for anyone else out there ? Would it make sense to fix > it ? I don't know if it is a concern, but if we're going to fix it, we should probably do it

Re: [PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-13 Thread Mathieu Desnoyers
* Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: > > [...] > > kallsyms returns the first symbol encountered, even though it is weak, > > when it should in fact return sys_ni_syscall. > > Is it a concern for anyone else out there ? Would it make sense to fix > > it ? > > I don't know if it is a

[PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-13 Thread Mathieu Desnoyers
[...] kallsyms returns the first symbol encountered, even though it is weak, when it should in fact return sys_ni_syscall. Is it a concern for anyone else out there ? Would it make sense to fix it ? I don't know if it is a concern, but if we're going to fix it, we should probably do it in

Re: [PATCH] Kallsyms Should Prefer Non Weak Symbols

2007-11-13 Thread Mathieu Desnoyers
* Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: [...] kallsyms returns the first symbol encountered, even though it is weak, when it should in fact return sys_ni_syscall. Is it a concern for anyone else out there ? Would it make sense to fix it ? I don't know if it is a concern, but if