Re: [PATCH] MIPS: Octeon: assign bool true/false not 1/0

2018-06-19 Thread Paul Burton
Hi Nicholas, On Sat, Jun 16, 2018 at 09:26:32AM +0200, Nicholas Mc Guire wrote: > Booleans should be assigned true/false not 1/0 as comparison is not needed > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located by scripts/coccinelle/misc/boolinit.cocci >

Re: [PATCH] MIPS: Octeon: assign bool true/false not 1/0

2018-06-19 Thread Paul Burton
Hi Nicholas, On Sat, Jun 16, 2018 at 09:26:32AM +0200, Nicholas Mc Guire wrote: > Booleans should be assigned true/false not 1/0 as comparison is not needed > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located by scripts/coccinelle/misc/boolinit.cocci >

[PATCH] MIPS: Octeon: assign bool true/false not 1/0

2018-06-16 Thread Nicholas Mc Guire
Booleans should be assigned true/false not 1/0 as comparison is not needed Signed-off-by: Nicholas Mc Guire --- Problem located by scripts/coccinelle/misc/boolinit.cocci ./arch/mips/cavium-octeon/octeon-irq.c:817:3-13: WARNING: Assignment of bool to 0/1 Patch was compile tested with:

[PATCH] MIPS: Octeon: assign bool true/false not 1/0

2018-06-16 Thread Nicholas Mc Guire
Booleans should be assigned true/false not 1/0 as comparison is not needed Signed-off-by: Nicholas Mc Guire --- Problem located by scripts/coccinelle/misc/boolinit.cocci ./arch/mips/cavium-octeon/octeon-irq.c:817:3-13: WARNING: Assignment of bool to 0/1 Patch was compile tested with: