How about this to handle the "call yourself" semantic?
In the other archs, there is more factoring of smp call code, and more care in
the use of get_cpu(). That can be a follow-up MIPS patch.
Signed-off-by: Peter Watkins <[EMAIL PROTECTED]>
---
diff --git a/arch/mips/kernel/smp.c
Hello,
Thanks for catching this. We will resubmit an updated version.
PHil, Peter, would you be able/willing to do this?
thanks.
On Sat, Jul 28, 2007 at 11:19:50AM +0200, Heiko Carstens wrote:
> On Fri, Jul 27, 2007 at 06:53:23AM -0700, Stephane Eranian wrote:
> > Ralf,
> >
> > Here is take
Hello,
Thanks for catching this. We will resubmit an updated version.
PHil, Peter, would you be able/willing to do this?
thanks.
On Sat, Jul 28, 2007 at 11:19:50AM +0200, Heiko Carstens wrote:
On Fri, Jul 27, 2007 at 06:53:23AM -0700, Stephane Eranian wrote:
Ralf,
Here is take 2.
How about this to handle the call yourself semantic?
In the other archs, there is more factoring of smp call code, and more care in
the use of get_cpu(). That can be a follow-up MIPS patch.
Signed-off-by: Peter Watkins [EMAIL PROTECTED]
---
diff --git a/arch/mips/kernel/smp.c
Heiko Carstens wrote:
This will not do the right thing. Semantics of smp_call_function_single()
changed recently. It now is supposed to call func() locally with irqs
disabled if cpu == smp_processor_id(). See i386/x86_64 and powerpc.
Unfortunately ia64 hasn't been changed yet, so it will behave
Heiko Carstens wrote:
This will not do the right thing. Semantics of smp_call_function_single()
changed recently. It now is supposed to call func() locally with irqs
disabled if cpu == smp_processor_id(). See i386/x86_64 and powerpc.
Unfortunately ia64 hasn't been changed yet, so it will behave
On Fri, Jul 27, 2007 at 06:53:23AM -0700, Stephane Eranian wrote:
> Ralf,
>
> Here is take 2.
>
> [MIPS] add smp_call_function_single (take 2)
>
> signed-off-by: Stephane Eranian <[EMAIL PROTECTED]>
> signed-off-by: Phil Mucci <[EMAIL PROTECTED]>
>
> diff --git a/arch/mips/kernel/smp.c
On Fri, Jul 27, 2007 at 06:53:23AM -0700, Stephane Eranian wrote:
Ralf,
Here is take 2.
[MIPS] add smp_call_function_single (take 2)
signed-off-by: Stephane Eranian [EMAIL PROTECTED]
signed-off-by: Phil Mucci [EMAIL PROTECTED]
diff --git a/arch/mips/kernel/smp.c
Ralf,
Here is take 2.
[MIPS] add smp_call_function_single (take 2)
signed-off-by: Stephane Eranian <[EMAIL PROTECTED]>
signed-off-by: Phil Mucci <[EMAIL PROTECTED]>
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index be7362b..d47234c 100644
--- a/arch/mips/kernel/smp.c
+++
On Fri, Jul 27, 2007 at 05:44:51AM -0700, Stephane Eranian wrote:
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index be7362b..9e376e2 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -193,6 +193,53 @@ void smp_call_function_interrupt(void)
> }
>
[MIPS] add smp_call_function_single()
signed-off-by: Stephane Eranian <[EMAIL PROTECTED]>
signed-off-by: Phil Mucci <[EMAIL PROTECTED]>
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index be7362b..9e376e2 100644
--- a/arch/mips/kernel/smp.c
+++
[MIPS] add smp_call_function_single()
signed-off-by: Stephane Eranian [EMAIL PROTECTED]
signed-off-by: Phil Mucci [EMAIL PROTECTED]
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index be7362b..9e376e2 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
Ralf,
Here is take 2.
[MIPS] add smp_call_function_single (take 2)
signed-off-by: Stephane Eranian [EMAIL PROTECTED]
signed-off-by: Phil Mucci [EMAIL PROTECTED]
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index be7362b..d47234c 100644
--- a/arch/mips/kernel/smp.c
+++
On Fri, Jul 27, 2007 at 05:44:51AM -0700, Stephane Eranian wrote:
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index be7362b..9e376e2 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -193,6 +193,53 @@ void smp_call_function_interrupt(void)
}
}
14 matches
Mail list logo
