Re: [PATCH] MIPS: Fix module.c build for 32 bit

2012-08-19 Thread Rusty Russell
On Tue, 14 Aug 2012 17:13:45 +0200, Ralf Baechle wrote: > Fixes build failure introduced by "Make most arch asm/module.h files use > asm-generic/module.h" by moving all the RELA processing code to a > separate file to be used only for RELA processing on 64-bit kernels. > > CC

Re: [PATCH] MIPS: Fix module.c build for 32 bit

2012-08-19 Thread Rusty Russell
On Tue, 14 Aug 2012 17:13:45 +0200, Ralf Baechle r...@linux-mips.org wrote: Fixes build failure introduced by Make most arch asm/module.h files use asm-generic/module.h by moving all the RELA processing code to a separate file to be used only for RELA processing on 64-bit kernels. CC

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-16 Thread Rusty Russell
On Wed, 15 Aug 2012 09:34:58 +0100, David Howells wrote: > Rusty Russell wrote: > > > For a build fix > > Linux hasn't pulled the asm-generic cleanup patch yet - you missed the merge > window, I think. Jonas detected the problem in linux-next. Yes, I missed the window but asked Linus to

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-16 Thread Rusty Russell
On Wed, 15 Aug 2012 09:34:58 +0100, David Howells dhowe...@redhat.com wrote: Rusty Russell ru...@rustcorp.com.au wrote: For a build fix Linux hasn't pulled the asm-generic cleanup patch yet - you missed the merge window, I think. Jonas detected the problem in linux-next. Yes, I

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-15 Thread David Howells
Rusty Russell wrote: > For a build fix Linux hasn't pulled the asm-generic cleanup patch yet - you missed the merge window, I think. Jonas detected the problem in linux-next. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-15 Thread David Howells
Rusty Russell ru...@rustcorp.com.au wrote: For a build fix Linux hasn't pulled the asm-generic cleanup patch yet - you missed the merge window, I think. Jonas detected the problem in linux-next. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-14 Thread Rusty Russell
On Tue, 14 Aug 2012 15:08:10 +0100, David Howells wrote: > Rusty Russell wrote: > > > Yep, thanks. And might as well sent them straight to Linus; since > > linux-next didn't catch this, there's little point baking them there if > > we have some acks. > > > > If he misses it, I'll grab them. >

Re: [PATCH] MIPS: Fix module.c build for 32 bit

2012-08-14 Thread David Howells
Ralf Baechle wrote: > +extern int apply_r_mips_none(struct module *me, u32 *location, Elf_Addr v); This needs to be in a header file, not a .c file. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

[PATCH] MIPS: Fix module.c build for 32 bit

2012-08-14 Thread Ralf Baechle
Fixes build failure introduced by "Make most arch asm/module.h files use asm-generic/module.h" by moving all the RELA processing code to a separate file to be used only for RELA processing on 64-bit kernels. CC arch/mips/kernel/module.o arch/mips/kernel/module.c:250:14: error:

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-14 Thread David Howells
Rusty Russell wrote: > Yep, thanks. And might as well sent them straight to Linus; since > linux-next didn't catch this, there's little point baking them there if > we have some acks. > > If he misses it, I'll grab them. It might have to wait for the next merge window. David -- To

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-14 Thread David Howells
Rusty Russell ru...@rustcorp.com.au wrote: Yep, thanks. And might as well sent them straight to Linus; since linux-next didn't catch this, there's little point baking them there if we have some acks. If he misses it, I'll grab them. It might have to wait for the next merge window. David

[PATCH] MIPS: Fix module.c build for 32 bit

2012-08-14 Thread Ralf Baechle
Fixes build failure introduced by Make most arch asm/module.h files use asm-generic/module.h by moving all the RELA processing code to a separate file to be used only for RELA processing on 64-bit kernels. CC arch/mips/kernel/module.o arch/mips/kernel/module.c:250:14: error:

Re: [PATCH] MIPS: Fix module.c build for 32 bit

2012-08-14 Thread David Howells
Ralf Baechle r...@linux-mips.org wrote: +extern int apply_r_mips_none(struct module *me, u32 *location, Elf_Addr v); This needs to be in a header file, not a .c file. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-14 Thread Rusty Russell
On Tue, 14 Aug 2012 15:08:10 +0100, David Howells dhowe...@redhat.com wrote: Rusty Russell ru...@rustcorp.com.au wrote: Yep, thanks. And might as well sent them straight to Linus; since linux-next didn't catch this, there's little point baking them there if we have some acks. If he

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-13 Thread Rusty Russell
On Mon, 13 Aug 2012 16:39:42 +0100, David Howells wrote: > > Hi Rusty, > > I've fixed up my patch for ARM and pulled Jonas's patch on top of that. Do > you want me to merge them together? Yep, thanks. And might as well sent them straight to Linus; since linux-next didn't catch this, there's

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-13 Thread David Howells
Hi Rusty, I've fixed up my patch for ARM and pulled Jonas's patch on top of that. Do you want me to merge them together? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-13 Thread David Howells
Hi Rusty, I've fixed up my patch for ARM and pulled Jonas's patch on top of that. Do you want me to merge them together? David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-13 Thread Rusty Russell
On Mon, 13 Aug 2012 16:39:42 +0100, David Howells dhowe...@redhat.com wrote: Hi Rusty, I've fixed up my patch for ARM and pulled Jonas's patch on top of that. Do you want me to merge them together? Yep, thanks. And might as well sent them straight to Linus; since linux-next didn't catch

[PATCH] MIPS: fix module.c build for 32 bit

2012-08-07 Thread Jonas Gorski
Fixes the following build failure introduced by "Make most arch asm/module.h files use asm-generic/module.h". CC arch/mips/kernel/module.o arch/mips/kernel/module.c:250:14: error: 'reloc_handlers_rela' defined but not used [-Werror=unused-variable] cc1: all warnings being treated as

[PATCH] MIPS: fix module.c build for 32 bit

2012-08-07 Thread Jonas Gorski
Fixes the following build failure introduced by Make most arch asm/module.h files use asm-generic/module.h. CC arch/mips/kernel/module.o arch/mips/kernel/module.c:250:14: error: 'reloc_handlers_rela' defined but not used [-Werror=unused-variable] cc1: all warnings being treated as errors