Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2014 12:27 AM, Nick Krause wrote: From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 From: Nick Date: Sun, 15 Jun 2014 16:16:14 -0400 Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers() Here is the fixed patch changed return

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2014 12:27 AM, Nick Krause wrote: From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 From: Nick xerofo...@gmail.com Date: Sun, 15 Jun 2014 16:16:14 -0400 Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers() Here is the fixed patch

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread Nick Krause
Fair enjoy I was wondering if it fails I can run a goto statement and then free the memory for the tx as needed. Cheers Nick P.S. That was really stupid I didn't think that through at all :) On Sun, Jun 15, 2014 at 10:26 PM, David Miller wrote: > From: Nick Krause > Date: Sun, 15 Jun 2014

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread David Miller
From: Nick Krause Date: Sun, 15 Jun 2014 16:27:23 -0400 > From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 > From: Nick > Date: Sun, 15 Jun 2014 16:16:14 -0400 > Subject: [PATCHv2] Fixes return logic of function of > pch_gbe_alloc_tx_buffers() > Here is the fixed patch

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread Nick Krause
>From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 From: Nick Date: Sun, 15 Jun 2014 16:16:14 -0400 Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers() Here is the fixed patch changed return type of function to int in order to use return -ENOMEM as

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread David Miller
From: Nick Date: Sun, 15 Jun 2014 00:05:39 -0400 > Signed-off-by: Nick > --- > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c >

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread David Miller
From: Nick xerofo...@gmail.com Date: Sun, 15 Jun 2014 00:05:39 -0400 Signed-off-by: Nick xerofo...@gmail.com --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread Nick Krause
From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 From: Nick xerofo...@gmail.com Date: Sun, 15 Jun 2014 16:16:14 -0400 Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers() Here is the fixed patch changed return type of function to int in order to use

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread David Miller
From: Nick Krause xerofo...@gmail.com Date: Sun, 15 Jun 2014 16:27:23 -0400 From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 From: Nick xerofo...@gmail.com Date: Sun, 15 Jun 2014 16:16:14 -0400 Subject: [PATCHv2] Fixes return logic of function of

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-15 Thread Nick Krause
Fair enjoy I was wondering if it fails I can run a goto statement and then free the memory for the tx as needed. Cheers Nick P.S. That was really stupid I didn't think that through at all :) On Sun, Jun 15, 2014 at 10:26 PM, David Miller da...@davemloft.net wrote: From: Nick Krause

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-14 Thread Nick Krause
I am resending this patch as the email for Ben is wrong in the maintainer script due to getting automated message from solarflare. Signed-off-by: Nick --- drivers/net/ethernet/oki-semi/ pch_gbe/pch_gbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-14 Thread Nick
Signed-off-by: Nick --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 73e6683..704cf63 100644 ---

[PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-14 Thread Nick
Signed-off-by: Nick xerofo...@gmail.com --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 73e6683..704cf63 100644 ---

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-14 Thread Nick Krause
I am resending this patch as the email for Ben is wrong in the maintainer script due to getting automated message from solarflare. Signed-off-by: Nick xerofo...@gmail.com --- drivers/net/ethernet/oki-semi/ pch_gbe/pch_gbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git