Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: > Several of these goto exit; uses should be direct returns > as skb is not yet initialized by nci_hci_get_param(). > > Miscellanea: > > o Use !memcmp instead of memcmp() == 0 > o Remove unnecessary goto from if () {... goto

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;}

[PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;} else {...} exit: Signed-off-by: Joe Perches --- net/nfc/nci/hci.c | 11

[PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;} else {...} exit: Signed-off-by: Joe Perches j...@perches.com ---