Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces

2007-04-23 Thread Alan Cox
On Mon, 23 Apr 2007 10:21:14 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > This is lacking a changelog. What's the purpose of changing this? > Is pci_find_slot() obsolete and going

Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces

2007-04-23 Thread Dave Jones
On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> This is lacking a changelog. What's the purpose of changing this? Is pci_find_slot() obsolete and going away? (If so, it should be marked as such). These devices aren't hotpluggable, so I'm

[PATCH] Nvidia AGP: Use refcount aware PCI interfaces

2007-04-23 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c --- linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-12

[PATCH] Nvidia AGP: Use refcount aware PCI interfaces

2007-04-23 Thread Alan Cox
Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c --- linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-12

Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces

2007-04-23 Thread Dave Jones
On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] This is lacking a changelog. What's the purpose of changing this? Is pci_find_slot() obsolete and going away? (If so, it should be marked as such). These devices aren't hotpluggable, so I'm not

Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces

2007-04-23 Thread Alan Cox
On Mon, 23 Apr 2007 10:21:14 -0400 Dave Jones [EMAIL PROTECTED] wrote: On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] This is lacking a changelog. What's the purpose of changing this? Is pci_find_slot() obsolete and going away? (If so,