Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-28 Thread Sinan Kaya
On 9/28/2018 6:24 AM, p...@codeaurora.org wrote: 1) Does that seem like the right place? IMO, I think best is to call after driver callback in PCI core. A driver specific action can cause some of these errors. We don't want to return with outstanding errors. 2) I guess all we need now would 

Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-28 Thread poza
On 2018-09-27 03:38, Bjorn Helgaas wrote: [+cc Sinan, LKML] On Tue, Sep 18, 2018 at 04:20:29AM -0400, Oza Pawandeep wrote: PCI based device drivers handles ERR_NONFATAL by registering pci_error_handlers. some of the drivers clear AER uncorrectable status in slot_reset while some in resume. Dr

Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-26 Thread Bjorn Helgaas
[+cc Sinan, LKML] On Tue, Sep 18, 2018 at 04:20:29AM -0400, Oza Pawandeep wrote: > PCI based device drivers handles ERR_NONFATAL by registering > pci_error_handlers. some of the drivers clear AER uncorrectable status > in slot_reset while some in resume. > > Drivers should not have responsibilit

Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-18 Thread poza
On 2018-09-18 20:00, Sinan Kaya wrote: On 9/18/2018 4:20 AM, Oza Pawandeep wrote: +++ b/drivers/pci/pcie/err.c @@ -265,6 +265,8 @@ static pci_ers_result_t broadcast_error_message(struct pci_dev *dev, * The error is non fatal so the bus is ok; just invoke * the

Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-18 Thread Sinan Kaya
On 9/18/2018 4:20 AM, Oza Pawandeep wrote: +++ b/drivers/pci/pcie/err.c @@ -265,6 +265,8 @@ static pci_ers_result_t broadcast_error_message(struct pci_dev *dev, * The error is non fatal so the bus is ok; just invoke * the callback for the function that logged th

[PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-18 Thread Oza Pawandeep
PCI based device drivers handles ERR_NONFATAL by registering pci_error_handlers. some of the drivers clear AER uncorrectable status in slot_reset while some in resume. Drivers should not have responsibility of clearing the AER status, instead shall be done by error and recovery framework defined