Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-28 Thread Bjorn Helgaas
On Sun, Mar 28, 2021 at 12:04:35AM +0100, Heiner Kallweit wrote: > On 26.03.2021 22:26, Bjorn Helgaas wrote: > > [+cc Randy, Andrew (though I'm sure you have zero interest in this > > ancient question :))] > > > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > >> pci_set_mwi()

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-27 Thread Heiner Kallweit
On 26.03.2021 22:26, Bjorn Helgaas wrote: > [+cc Randy, Andrew (though I'm sure you have zero interest in this > ancient question :))] > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: >> pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the >> former one is

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-26 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 11:42:46PM +0200, Andy Shevchenko wrote: > On Fri, Mar 26, 2021 at 04:26:55PM -0500, Bjorn Helgaas wrote: > > [+cc Randy, Andrew (though I'm sure you have zero interest in this > > ancient question :))] > > > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-26 Thread Andy Shevchenko
On Fri, Mar 26, 2021 at 04:26:55PM -0500, Bjorn Helgaas wrote: > [+cc Randy, Andrew (though I'm sure you have zero interest in this > ancient question :))] > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-26 Thread Bjorn Helgaas
[+cc Randy, Andrew (though I'm sure you have zero interest in this ancient question :))] On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Andy Shevchenko
On Wed, Dec 9, 2020 at 12:59 PM Andy Shevchenko wrote: > On Wed, Dec 9, 2020 at 10:35 AM Heiner Kallweit wrote: ... > > -int pci_try_set_mwi(struct pci_dev *dev) > > -{ > > > -#ifdef PCI_DISABLE_MWI > > - return 0; > > -#else > > - return pci_set_mwi(dev); > > -#endif > > This

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Andy Shevchenko
On Wed, Dec 9, 2020 at 10:35 AM Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of However also -> However > pci_set_mwi() have a comment that it's an optional feature. I don't >

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Lee Jones
On Wed, 09 Dec 2020, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Peter Chen
On 20-12-09 09:31:21, Heiner Kallweit wrote: > drivers/usb/chipidea/ci_hdrc_pci.c| 2 +- For chipidea changes: Acked-by: Peter Chen Peter > drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +- > drivers/usb/gadget/udc/net2280.c | 2 +- >

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Vinod Koul
On 09-12-20, 09:31, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this

Re: [PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Kalle Valo
Heiner Kallweit writes: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this separation and the use

[PATCH] PCI: Remove pci_try_set_mwi

2020-12-09 Thread Heiner Kallweit
pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the former one is declared as __must_check. However also some callers of pci_set_mwi() have a comment that it's an optional feature. I don't think there's much sense in this separation and the use of __must_check. Therefore remove