Re: [PATCH] PCI: Unify pci and normal dma direction definition

2018-07-17 Thread Yang, Shunyong
Hi, Christoph,   I will send a v2 according to your comments. Thanks. Shunyong. On Tue, 2018-07-17 at 07:03 -0700, Christoph Hellwig wrote: > > > > diff --git a/include/linux/dma-direction.h b/include/linux/dma- > > direction.h > > index 3649a031893a..9d52716e9218 100644 > > ---

Re: [PATCH] PCI: Unify pci and normal dma direction definition

2018-07-17 Thread Yang, Shunyong
Hi, Christoph,   I will send a v2 according to your comments. Thanks. Shunyong. On Tue, 2018-07-17 at 07:03 -0700, Christoph Hellwig wrote: > > > > diff --git a/include/linux/dma-direction.h b/include/linux/dma- > > direction.h > > index 3649a031893a..9d52716e9218 100644 > > ---

Re: [PATCH] PCI: Unify pci and normal dma direction definition

2018-07-17 Thread Christoph Hellwig
> diff --git a/include/linux/dma-direction.h b/include/linux/dma-direction.h > index 3649a031893a..9d52716e9218 100644 > --- a/include/linux/dma-direction.h > +++ b/include/linux/dma-direction.h > @@ -2,7 +2,7 @@ > #ifndef _LINUX_DMA_DIRECTION_H > #define _LINUX_DMA_DIRECTION_H > /* > - * These

Re: [PATCH] PCI: Unify pci and normal dma direction definition

2018-07-17 Thread Christoph Hellwig
> diff --git a/include/linux/dma-direction.h b/include/linux/dma-direction.h > index 3649a031893a..9d52716e9218 100644 > --- a/include/linux/dma-direction.h > +++ b/include/linux/dma-direction.h > @@ -2,7 +2,7 @@ > #ifndef _LINUX_DMA_DIRECTION_H > #define _LINUX_DMA_DIRECTION_H > /* > - * These

[PATCH] PCI: Unify pci and normal dma direction definition

2018-07-13 Thread Shunyong Yang
Current DMA direction definitions in pci-dma-compat.h and dma-direction.h are mirrored in value. Unify them to enhance readability and avoid possible inconsistency. Cc: Joey Zheng Signed-off-by: Shunyong Yang --- include/linux/dma-direction.h | 2 +- include/linux/pci-dma-compat.h | 8

[PATCH] PCI: Unify pci and normal dma direction definition

2018-07-13 Thread Shunyong Yang
Current DMA direction definitions in pci-dma-compat.h and dma-direction.h are mirrored in value. Unify them to enhance readability and avoid possible inconsistency. Cc: Joey Zheng Signed-off-by: Shunyong Yang --- include/linux/dma-direction.h | 2 +- include/linux/pci-dma-compat.h | 8