Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-23 Thread Bjorn Helgaas
On Wed, Oct 23, 2019 at 04:22:43PM +0800, Yunsheng Lin wrote: > On 2019/10/23 5:04, Bjorn Helgaas wrote: > > On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: > > I think the underlying problem you're addressing is that: > > > > - NUMA_NO_NODE == -1, > > - dev_to_node(dev) may

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-23 Thread Yunsheng Lin
On 2019/10/22 21:55, Robin Murphy wrote: > On 21/10/2019 05:05, Yunsheng Lin wrote: >> On 2019/10/19 16:34, Christoph Hellwig wrote: >>> On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: +if (nr_node_ids > 1 && dev_to_node(bus->bridge) == NUMA_NO_NODE) +

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-23 Thread Yunsheng Lin
On 2019/10/23 5:04, Bjorn Helgaas wrote: > On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: >> As the disscusion in [1]: > > We need to justify this patch right here in the commit log, not with a > pointer to a 50+ message email thread. Ok, thanks. > >> A PCI device really _MUST_

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-22 Thread Bjorn Helgaas
On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: > As the disscusion in [1]: We need to justify this patch right here in the commit log, not with a pointer to a 50+ message email thread. > A PCI device really _MUST_ have a node assigned. No, it's not really essential. It's *nice*

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-22 Thread Robin Murphy
On 21/10/2019 05:05, Yunsheng Lin wrote: On 2019/10/19 16:34, Christoph Hellwig wrote: On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: + if (nr_node_ids > 1 && dev_to_node(bus->bridge) == NUMA_NO_NODE) + dev_err(bus->bridge, FW_BUG "No node assigned on NUMA

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-20 Thread Yunsheng Lin
On 2019/10/19 16:34, Christoph Hellwig wrote: > On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: >> +if (nr_node_ids > 1 && dev_to_node(bus->bridge) == NUMA_NO_NODE) >> +dev_err(bus->bridge, FW_BUG "No node assigned on NUMA capable >> HW by BIOS. Please contact your

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-19 Thread Christoph Hellwig
On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: > + if (nr_node_ids > 1 && dev_to_node(bus->bridge) == NUMA_NO_NODE) > + dev_err(bus->bridge, FW_BUG "No node assigned on NUMA capable > HW by BIOS. Please contact your vendor for updates.\n"); > + The whole idea of

[PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-19 Thread Yunsheng Lin
As the disscusion in [1]: A PCI device really _MUST_ have a node assigned. It is possible to have a PCI bridge shared between two nodes, such that the PCI devices have equidistance. But the moment you scale this out, you either get devices that are 'local' to a package while having multiple