Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-31 Thread Greg KH
On Mon, Jan 24, 2005 at 12:10:25PM -0800, long wrote: > On Tuesday, January 18, 2005 5:03 PM Greg KH wrote: > >> > > >> >That would be great, but it doesn't show up that way on my box. All > >> >of > >> >the portX devices are in /sys/devices/ which is what I don't think > >> >you > >> >want. I

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-31 Thread Greg KH
On Mon, Jan 24, 2005 at 12:10:25PM -0800, long wrote: On Tuesday, January 18, 2005 5:03 PM Greg KH wrote: That would be great, but it doesn't show up that way on my box. All of the portX devices are in /sys/devices/ which is what I don't think you want. I would love for them to

Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-24 Thread long
On Tuesday, January 18, 2005 5:03 PM Greg KH wrote: >> > >> >That would be great, but it doesn't show up that way on my box. All >> >of >> >the portX devices are in /sys/devices/ which is what I don't think >> >you >> >want. I would love for them to have the parent of the pci_dev >> >structure

Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-24 Thread long
On Tuesday, January 18, 2005 5:03 PM Greg KH wrote: That would be great, but it doesn't show up that way on my box. All of the portX devices are in /sys/devices/ which is what I don't think you want. I would love for them to have the parent of the pci_dev structure :) Agree. Thanks

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread Greg KH
On Tue, Jan 18, 2005 at 05:59:44PM -0800, long wrote: > On Tue Jan 18 11:41:01 2005 Greg KH wrote: > >> > > >> > > >> > This puts all of the pcie "port" structures in /sys/devices/ Shouldn't > >> > you make the parent of the device you create point to the pci_dev > >> > structure that's passed

Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread long
On Tue Jan 18 11:41:01 2005 Greg KH wrote: >> > >> > >> > This puts all of the pcie "port" structures in /sys/devices/ Shouldn't >> > you make the parent of the device you create point to the pci_dev >> > structure that's passed into this function? That would make the sysfs >> > tree a lot saner

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread Greg KH
On Tue, Jan 18, 2005 at 11:28:57AM -0800, long wrote: > On Mon, 17 Jan 2005 15:49:08 -0800 Greg KH wrote: > > > +int pcie_port_device_register(struct pci_dev *dev) > > > +{ > > > + struct pcie_device *parent; > > > + int status, type, capabilities, irq_mode, i; > > > + int

Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread long
On Mon, 17 Jan 2005 15:49:08 -0800 Greg KH wrote: > > +int pcie_port_device_register(struct pci_dev *dev) > > +{ > > + struct pcie_device *parent; > > + int status, type, capabilities, irq_mode, i; > > + int vectors[PCIE_PORT_DEVICE_MAXSERVICES]; > > + u16 reg16; > > + > > + /* Get port

Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread long
On Mon, 17 Jan 2005 15:49:08 -0800 Greg KH wrote: +int pcie_port_device_register(struct pci_dev *dev) +{ + struct pcie_device *parent; + int status, type, capabilities, irq_mode, i; + int vectors[PCIE_PORT_DEVICE_MAXSERVICES]; + u16 reg16; + + /* Get port type */ +

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread Greg KH
On Tue, Jan 18, 2005 at 11:28:57AM -0800, long wrote: On Mon, 17 Jan 2005 15:49:08 -0800 Greg KH wrote: +int pcie_port_device_register(struct pci_dev *dev) +{ + struct pcie_device *parent; + int status, type, capabilities, irq_mode, i; + int vectors[PCIE_PORT_DEVICE_MAXSERVICES];

Re:[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread long
On Tue Jan 18 11:41:01 2005 Greg KH wrote: This puts all of the pcie port structures in /sys/devices/ Shouldn't you make the parent of the device you create point to the pci_dev structure that's passed into this function? That would make the sysfs tree a lot saner I think. The

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-18 Thread Greg KH
On Tue, Jan 18, 2005 at 05:59:44PM -0800, long wrote: On Tue Jan 18 11:41:01 2005 Greg KH wrote: This puts all of the pcie port structures in /sys/devices/ Shouldn't you make the parent of the device you create point to the pci_dev structure that's passed into this function? That

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-17 Thread Greg KH
On Mon, Jan 17, 2005 at 02:01:52PM -0800, Greg KH wrote: > +int pcie_port_device_register(struct pci_dev *dev) > +{ > + struct pcie_device *parent; > + int status, type, capabilities, irq_mode, i; > + int vectors[PCIE_PORT_DEVICE_MAXSERVICES]; > + u16 reg16; > + > + /* Get port

[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-17 Thread Greg KH
ChangeSet 1.2329.2.1, 2005/01/14 15:56:18-08:00, [EMAIL PROTECTED] [PATCH] PCI: add PCI Express Port Bus Driver subsystem Signed-off-by: T. Long Nguyen <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Documentation/PCIEBUS-HOWTO.txt | 217

[PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-17 Thread Greg KH
ChangeSet 1.2329.2.1, 2005/01/14 15:56:18-08:00, [EMAIL PROTECTED] [PATCH] PCI: add PCI Express Port Bus Driver subsystem Signed-off-by: T. Long Nguyen [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Documentation/PCIEBUS-HOWTO.txt | 217 ++ arch/i386

Re: [PATCH] PCI: add PCI Express Port Bus Driver subsystem

2005-01-17 Thread Greg KH
On Mon, Jan 17, 2005 at 02:01:52PM -0800, Greg KH wrote: +int pcie_port_device_register(struct pci_dev *dev) +{ + struct pcie_device *parent; + int status, type, capabilities, irq_mode, i; + int vectors[PCIE_PORT_DEVICE_MAXSERVICES]; + u16 reg16; + + /* Get port type */