Re: [PATCH] PWM: atmel-pwm: use request/free instead of enable/disable

2013-09-29 Thread Alexandre Belloni
On 29/09/2013 12:12, Bo Shen wrote: > Hi Alexandre, > > On 9/28/2013 04:10, Alexandre Belloni wrote: >> I found that disabling a pwm while it is at a low level will actually >> put it >> back at a high level. The main symptom is that leds-pwm is calling >> pwm_disable() >> after setting the duty

Re: [PATCH] PWM: atmel-pwm: use request/free instead of enable/disable

2013-09-29 Thread Bo Shen
Hi Alexandre, On 9/28/2013 04:10, Alexandre Belloni wrote: I found that disabling a pwm while it is at a low level will actually put it back at a high level. The main symptom is that leds-pwm is calling pwm_disable() after setting the duty cycle to 0. Hence, instead of getting a switched off

Re: [PATCH] PWM: atmel-pwm: use request/free instead of enable/disable

2013-09-29 Thread Bo Shen
Hi Alexandre, On 9/28/2013 04:10, Alexandre Belloni wrote: I found that disabling a pwm while it is at a low level will actually put it back at a high level. The main symptom is that leds-pwm is calling pwm_disable() after setting the duty cycle to 0. Hence, instead of getting a switched off

Re: [PATCH] PWM: atmel-pwm: use request/free instead of enable/disable

2013-09-29 Thread Alexandre Belloni
On 29/09/2013 12:12, Bo Shen wrote: Hi Alexandre, On 9/28/2013 04:10, Alexandre Belloni wrote: I found that disabling a pwm while it is at a low level will actually put it back at a high level. The main symptom is that leds-pwm is calling pwm_disable() after setting the duty cycle to 0.

[PATCH] PWM: atmel-pwm: use request/free instead of enable/disable

2013-09-27 Thread Alexandre Belloni
I found that disabling a pwm while it is at a low level will actually put it back at a high level. The main symptom is that leds-pwm is calling pwm_disable() after setting the duty cycle to 0. Hence, instead of getting a switched off LED, you get an LED lit up at full brightness. Solve that by

[PATCH] PWM: atmel-pwm: use request/free instead of enable/disable

2013-09-27 Thread Alexandre Belloni
I found that disabling a pwm while it is at a low level will actually put it back at a high level. The main symptom is that leds-pwm is calling pwm_disable() after setting the duty cycle to 0. Hence, instead of getting a switched off LED, you get an LED lit up at full brightness. Solve that by