Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-12 Thread Gustavo A. R. Silva
Hi Leon, On 02/09/2018 11:36 AM, Gustavo A. R. Silva wrote: Quoting Leon Romanovsky : On Fri, Feb 09, 2018 at 09:56:00AM -0600, Gustavo A. R. Silva wrote: Quoting Leon Romanovsky : > On Fri, Feb 09, 2018 at 07:36:49AM -0600, Gustavo A. R. Silva wrote: > > Hi Leon, > > > > Quoting Leon Roma

Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-09 Thread Gustavo A. R. Silva
Quoting Leon Romanovsky : On Fri, Feb 09, 2018 at 09:56:00AM -0600, Gustavo A. R. Silva wrote: Quoting Leon Romanovsky : > On Fri, Feb 09, 2018 at 07:36:49AM -0600, Gustavo A. R. Silva wrote: > > Hi Leon, > > > > Quoting Leon Romanovsky : > > > > > On Fri, Feb 09, 2018 at 12:37:02AM -0600, G

Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-09 Thread Leon Romanovsky
On Fri, Feb 09, 2018 at 09:56:00AM -0600, Gustavo A. R. Silva wrote: > > Quoting Leon Romanovsky : > > > On Fri, Feb 09, 2018 at 07:36:49AM -0600, Gustavo A. R. Silva wrote: > > > Hi Leon, > > > > > > Quoting Leon Romanovsky : > > > > > > > On Fri, Feb 09, 2018 at 12:37:02AM -0600, Gustavo A. R. Si

Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-09 Thread Gustavo A. R. Silva
Quoting Leon Romanovsky : On Fri, Feb 09, 2018 at 07:36:49AM -0600, Gustavo A. R. Silva wrote: Hi Leon, Quoting Leon Romanovsky : > On Fri, Feb 09, 2018 at 12:37:02AM -0600, Gustavo A. R. Silva wrote: > > In case the message header and payload cannot be stored, function > > nlmsg_put returns

Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-09 Thread Leon Romanovsky
On Fri, Feb 09, 2018 at 07:36:49AM -0600, Gustavo A. R. Silva wrote: > Hi Leon, > > Quoting Leon Romanovsky : > > > On Fri, Feb 09, 2018 at 12:37:02AM -0600, Gustavo A. R. Silva wrote: > > > In case the message header and payload cannot be stored, function > > > nlmsg_put returns null. > > > > > >

Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-09 Thread Gustavo A. R. Silva
Hi Leon, Quoting Leon Romanovsky : On Fri, Feb 09, 2018 at 12:37:02AM -0600, Gustavo A. R. Silva wrote: In case the message header and payload cannot be stored, function nlmsg_put returns null. Fix this by adding multiple sanity checks and avoid a potential null dereference on _nlh_ when call

Re: [PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-09 Thread Leon Romanovsky
On Fri, Feb 09, 2018 at 12:37:02AM -0600, Gustavo A. R. Silva wrote: > In case the message header and payload cannot be stored, function > nlmsg_put returns null. > > Fix this by adding multiple sanity checks and avoid a potential > null dereference on _nlh_ when calling nlmsg_end. > > Addresses-Co

[PATCH] RDMA/nldev: Fix multiple potential NULL pointer dereferences

2018-02-08 Thread Gustavo A. R. Silva
In case the message header and payload cannot be stored, function nlmsg_put returns null. Fix this by adding multiple sanity checks and avoid a potential null dereference on _nlh_ when calling nlmsg_end. Addresses-Coverity-ID: 1454215 ("Dereference null return value") Addresses-Coverity-ID: 14542