Re: [PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-20 Thread Tim Waugh
On Sat, Nov 18, 2000 at 05:10:24PM -0500, John Cavan wrote: > it is. The new scsi error stuff does mention that drivers must > spinunlock/spinlock if it enables interrupts. Okay, I guess it is safe then. Tim. */ PGP signature

Re: [PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-20 Thread Tim Waugh
On Sat, Nov 18, 2000 at 05:10:24PM -0500, John Cavan wrote: it is. The new scsi error stuff does mention that drivers must spinunlock/spinlock if it enables interrupts. Okay, I guess it is safe then. Tim. */ PGP signature

Re: [PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-18 Thread John Cavan
Tim Waugh wrote: > > On Thu, Nov 16, 2000 at 09:50:40PM -0500, John Cavan wrote: > > > [...] This patch unlocks, allows the lowlevel driver to do it's > > probes, and then relocks. It could probably be more granular in the > > parport_pc code, but my own home tests show it to be working fine. >

Re: [PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-18 Thread John Cavan
Tim Waugh wrote: On Thu, Nov 16, 2000 at 09:50:40PM -0500, John Cavan wrote: [...] This patch unlocks, allows the lowlevel driver to do it's probes, and then relocks. It could probably be more granular in the parport_pc code, but my own home tests show it to be working fine. Is that

Re: [PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-17 Thread Tim Waugh
On Thu, Nov 16, 2000 at 09:50:40PM -0500, John Cavan wrote: > [...] This patch unlocks, allows the lowlevel driver to do it's > probes, and then relocks. It could probably be more granular in the > parport_pc code, but my own home tests show it to be working fine. Is that safe? Also, what bit

[PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-16 Thread John Cavan
Jens Axboe wrote: > Wouldn't it be more interesting to fix the reason the new error > handling code dies with imm and ppa? Yes it would... :o) I think I've got it here. The new error handling code spinlocks the IRQ which cause the lowlevel parport driver to choke. This patch unlocks, allows the

Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-16 Thread Jens Axboe
On Thu, Nov 16 2000, John Cavan wrote: > > Similar to the imm patch, it's working for me. > > > > John > > Again... not all screwed up... > patch -ur linux.clean/drivers/scsi/ppa.h linux.current/drivers/scsi/ppa.h > --- linux.clean/drivers/scsi/ppa.hThu Sep 14 20:27:05 2000 > +++

[PATCH] Re: Patch to fix lockup on ppa insert

2000-11-16 Thread John Cavan
John Cavan wrote: > > Similar to the imm patch, it's working for me. > > John Again... not all screwed up... patch -ur linux.clean/drivers/scsi/ppa.h linux.current/drivers/scsi/ppa.h --- linux.clean/drivers/scsi/ppa.h Thu Sep 14 20:27:05 2000 +++ linux.current/drivers/scsi/ppa.hThu

[PATCH] Re: Patch to fix lockup on ppa insert

2000-11-16 Thread John Cavan
John Cavan wrote: Similar to the imm patch, it's working for me. John Again... not all screwed up... patch -ur linux.clean/drivers/scsi/ppa.h linux.current/drivers/scsi/ppa.h --- linux.clean/drivers/scsi/ppa.h Thu Sep 14 20:27:05 2000 +++ linux.current/drivers/scsi/ppa.hThu Nov

Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-16 Thread Jens Axboe
On Thu, Nov 16 2000, John Cavan wrote: Similar to the imm patch, it's working for me. John Again... not all screwed up... patch -ur linux.clean/drivers/scsi/ppa.h linux.current/drivers/scsi/ppa.h --- linux.clean/drivers/scsi/ppa.hThu Sep 14 20:27:05 2000 +++

[PATCH] (new for ppa and imm) Re: [PATCH] Re: Patch to fix lockup on ppa insert

2000-11-16 Thread John Cavan
Jens Axboe wrote: Wouldn't it be more interesting to fix the reason the new error handling code dies with imm and ppa? Yes it would... :o) I think I've got it here. The new error handling code spinlocks the IRQ which cause the lowlevel parport driver to choke. This patch unlocks, allows the