Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-14 Thread Palmer Dabbelt
On Thu, 10 Sep 2015 04:18:05 PDT (-0700), dhowe...@redhat.com wrote: > David Howells wrote: > >> Rather than iterating through all the rest of your patches and saying the >> same >> thing, if there's something in a UAPI header that needs wrapping in >> __KERNEL__ >> to

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-10 Thread David Howells
David Howells wrote: > Rather than iterating through all the rest of your patches and saying the same > thing, if there's something in a UAPI header that needs wrapping in __KERNEL__ > to exclude it from userspace's use, then it should be transferred to the > non-UAPI

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-10 Thread David Howells
Rather than iterating through all the rest of your patches and saying the same thing, if there's something in a UAPI header that needs wrapping in __KERNEL__ to exclude it from userspace's use, then it should be transferred to the non-UAPI variant of that header (which should #include the UAPI

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-09 Thread Palmer Dabbelt
I cut the RISC-V stuff, but I intend to reply to it later. As you said, it's just a different topic. >>> However, I did see a lot of similar bugs now that you point me to it: >>> >>> $ grep -r \\\>> obj-tmp/usr/include/asm-generic/fcntl.h:#ifndef CONFIG_64BIT >>>

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-07 Thread Arnd Bergmann
On Tuesday 01 September 2015 17:10:10 Palmer Dabbelt wrote: > From: Palmer Dabbelt > > When working on the RISC-V port I noticed that F_SETLK64 was being > defined on our 64-bit platform, despite our port being so new that > we've only ever had the 64-bit file

Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-07 Thread Palmer Dabbelt
On Mon, 07 Sep 2015 06:16:37 PDT (-0700), a...@arndb.de wrote: > On Tuesday 01 September 2015 17:10:10 Palmer Dabbelt wrote: >> From: Palmer Dabbelt >> >> When working on the RISC-V port I noticed that F_SETLK64 was being >> defined on our 64-bit platform,

[PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h

2015-09-02 Thread Palmer Dabbelt
From: Palmer Dabbelt When working on the RISC-V port I noticed that F_SETLK64 was being defined on our 64-bit platform, despite our port being so new that we've only ever had the 64-bit file ops. Since there's not compat layer for these, this causes fcntl to