Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-05 Thread Steven Rostedt
On Thu, 5 Mar 2015 10:17:04 -0500 Dave Jones wrote: > Removing it entirely sounds like a much better choice, so I'd > wait for Namhyung to resend. Removing or just doing something small may be better. Those sleeps were added to my original tests because it sometimes had false failures. But tha

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-05 Thread Steven Rostedt
On Wed, 4 Mar 2015 21:44:57 +0900 Namhyung Kim wrote: > I think that there's no need to even call true or echo.. Ideally it shouldn't. But I if you noticed it expects 3 or more events in some cases. I believe without the sleep it would sometimes fail that. Is there a small command we can run ju

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-05 Thread Dave Jones
On Thu, Mar 05, 2015 at 08:14:42AM -0700, Shuah Khan wrote: > On 03/04/2015 06:18 PM, Michael Ellerman wrote: > > On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote: > >> > >> I think that there's no need to even call true or echo.. > >> > >> From 0549544e8e982df6478f11e2b4fe419f94c22434 M

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-05 Thread Shuah Khan
On 03/04/2015 06:18 PM, Michael Ellerman wrote: > On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote: >> >> I think that there's no need to even call true or echo.. >> >> From 0549544e8e982df6478f11e2b4fe419f94c22434 Mon Sep 17 00:00:00 2001 >> From: Namhyung Kim >> Date: Wed, 4 Mar 2015 21:26:

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-04 Thread Michael Ellerman
On Wed, 2015-03-04 at 21:44 +0900, Namhyung Kim wrote: > > I think that there's no need to even call true or echo.. > > From 0549544e8e982df6478f11e2b4fe419f94c22434 Mon Sep 17 00:00:00 2001 > From: Namhyung Kim > Date: Wed, 4 Mar 2015 21:26:38 +0900 > Subject: [PATCH] ftracetest: Do not use usl

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-04 Thread Namhyung Kim
Hello, On Wed, Mar 04, 2015 at 09:47:47PM +1100, Michael Ellerman wrote: > On Tue, 2015-03-03 at 17:05 -0700, Shuah Khan wrote: > > On 02/27/2015 08:16 PM, Namhyung Kim wrote: > > > On Tue, Feb 24, 2015 at 01:24:59PM -0500, Dave Jones wrote: > > >> On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah K

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-04 Thread Michael Ellerman
On Tue, 2015-03-03 at 17:05 -0700, Shuah Khan wrote: > On 02/27/2015 08:16 PM, Namhyung Kim wrote: > > On Tue, Feb 24, 2015 at 01:24:59PM -0500, Dave Jones wrote: > >> On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah Khan wrote: > >> > On 02/24/2015 11:18 AM, Steven Rostedt wrote: > >> > > > >>

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-03-03 Thread Shuah Khan
On 02/27/2015 08:16 PM, Namhyung Kim wrote: > Hi, > > On Tue, Feb 24, 2015 at 01:24:59PM -0500, Dave Jones wrote: >> On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah Khan wrote: >> > On 02/24/2015 11:18 AM, Steven Rostedt wrote: >> > > >> > > Shuah, >> > > >> > > Can you take this in your tr

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-02-27 Thread Namhyung Kim
Hi, On Tue, Feb 24, 2015 at 01:24:59PM -0500, Dave Jones wrote: > On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah Khan wrote: > > On 02/24/2015 11:18 AM, Steven Rostedt wrote: > > > > > > Shuah, > > > > > > Can you take this in your tree? > > > > Yes I can do that. This must be the origi

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-02-24 Thread Dave Jones
On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah Khan wrote: > On 02/24/2015 11:18 AM, Steven Rostedt wrote: > > > > Shuah, > > > > Can you take this in your tree? > > Yes I can do that. This must be the original patch email: > https://lkml.org/lkml/2015/2/24/435 Correct. Dave -

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-02-24 Thread Shuah Khan
On 02/24/2015 11:18 AM, Steven Rostedt wrote: > > Shuah, > > Can you take this in your tree? Yes I can do that. This must be the original patch email: https://lkml.org/lkml/2015/2/24/435 -- Shuah > > On Tue, 24 Feb 2015 11:19:27 -0500 > Dave Jones wrote: > >> usleep(1) is a Red Hat'ism (biz

Re: [PATCH] Remove redhat'ism from ftrace selftests.

2015-02-24 Thread Steven Rostedt
Shuah, Can you take this in your tree? On Tue, 24 Feb 2015 11:19:27 -0500 Dave Jones wrote: > usleep(1) is a Red Hat'ism (bizarrely provided by initscripts), > that isn't available on other distributions. > To make this work elsewhere, convert to using fractional > shell sleeps. > > Signed-of

[PATCH] Remove redhat'ism from ftrace selftests.

2015-02-24 Thread Dave Jones
usleep(1) is a Red Hat'ism (bizarrely provided by initscripts), that isn't available on other distributions. To make this work elsewhere, convert to using fractional shell sleeps. Signed-off-by: Dave Jones diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/