Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-26 Thread Dan Carpenter
On Tue, May 26, 2020 at 08:24:50PM +0530, GAURAV PATHAK wrote: > On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote: > > Your subject doesn't use the correct patch prefix please use. > > > > [PATCH] Staging: comedi: dt2814: remove unused assignments > > > > Please resend a v2. > > >

Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-26 Thread GAURAV PATHAK
On Tue, May 26, 2020 at 05:13:46PM +0300, Dan Carpenter wrote: > Your subject doesn't use the correct patch prefix please use. > > [PATCH] Staging: comedi: dt2814: remove unused assignments > > Please resend a v2. > > Correct the references to Sparse as well like Luc said. > > regards, > dan

Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-26 Thread Dan Carpenter
Your subject doesn't use the correct patch prefix please use. [PATCH] Staging: comedi: dt2814: remove unused assignments Please resend a v2. Correct the references to Sparse as well like Luc said. regards, dan carpenter

Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-24 Thread Luc Van Oostenryck
On Sun, May 24, 2020 at 07:02:20PM +0530, GAURAV PATHAK wrote: > > For few drivers, I am getting: > > CC [M] drivers/staging/vt6656/key.o > CHECK drivers/staging/vt6656/rf.c > /usr/lib/gcc/x86_64-linux-gnu/7/include/stddef.h:417:9: warning: preprocessor > token offsetof redefined >

Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-24 Thread Luc Van Oostenryck
On Sun, May 24, 2020 at 06:19:22PM +0530, GAURAV PATHAK wrote: > Thanks a lot for your reply. > I am trying to run sparse on drivers/staging directory, > but I am not getting any useful warnings. > Steps that I did: > > - Referred https://www.kernel.org/doc/man-pages/linux-next.html to get >

Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-24 Thread GAURAV PATHAK
Nevermind, my sparse version was broken. Installed sparse 0.6.1, but still no warnings from sparse in any of the directories in drivers staging. E.g.: make C=2 M=drivers/staging/sm750fb CHECK drivers/staging/sm750fb/sm750.c CHECK drivers/staging/sm750fb/sm750_hw.c CHECK

Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-24 Thread Luc Van Oostenryck
Hi, On Sun, May 24, 2020 at 05:06:18PM +0530, Gaurav Pathak wrote: > Silence following sparse warning: > drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’: > drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set > but not used

[PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.

2020-05-24 Thread Gaurav Pathak
Silence following sparse warning: drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’: drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] int data; ^~~~ drivers/staging/comedi/drivers/dt2814.c: In