Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-15 Thread Krzysztof Hałasa
Arnd Bergmann writes: > I'd start by copying the relevant nodes from > arch/arm/boot/dts/arm-realview-pb11mp.dts, which is the closest > I can think of. I've put together something completely untested > below. Thanks. I will try to handle that. 3+ weeks, unfortunately. Now, what

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-15 Thread Krzysztof Hałasa
Arnd Bergmann writes: > I'd start by copying the relevant nodes from > arch/arm/boot/dts/arm-realview-pb11mp.dts, which is the closest > I can think of. I've put together something completely untested > below. Thanks. I will try to handle that. 3+ weeks, unfortunately. Now, what do we do with

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-10 Thread Arnd Bergmann
On Friday, June 10, 2016 12:10:14 PM CEST Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > Before that, we were always setting both mrrs and mps. As we don't know > > who uses PCIE_BUS_PEER2PEER, maybe another option would be to add yet > > another pcie_bus_config value for

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-10 Thread Arnd Bergmann
On Friday, June 10, 2016 12:10:14 PM CEST Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > Before that, we were always setting both mrrs and mps. As we don't know > > who uses PCIE_BUS_PEER2PEER, maybe another option would be to add yet > > another pcie_bus_config value for this particular

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-10 Thread Krzysztof Hałasa
Arnd Bergmann writes: > Before that, we were always setting both mrrs and mps. As we don't know > who uses PCIE_BUS_PEER2PEER, maybe another option would be to add yet > another pcie_bus_config value for this particular quirk? It would be a safe approach. Or, maybe another

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-10 Thread Krzysztof Hałasa
Arnd Bergmann writes: > Before that, we were always setting both mrrs and mps. As we don't know > who uses PCIE_BUS_PEER2PEER, maybe another option would be to add yet > another pcie_bus_config value for this particular quirk? It would be a safe approach. Or, maybe another non-pcie_bus_config

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-09 Thread Bjorn Helgaas
On Wed, Jun 01, 2016 at 11:09:47PM +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 1:08:59 PM CEST Krzysztof Hałasa wrote: > > Bjorn Helgaas writes: > > > > > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > > > > > Krzysztof reported that this

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-09 Thread Bjorn Helgaas
On Wed, Jun 01, 2016 at 11:09:47PM +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 1:08:59 PM CEST Krzysztof Hałasa wrote: > > Bjorn Helgaas writes: > > > > > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > > > > > Krzysztof reported that this change broke Cavium

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-09 Thread Arnd Bergmann
On Thursday, June 9, 2016 7:42:24 AM CEST Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > What exactly is the problem we are seeing, and is there a way to fix > > it on top of my patch? Are we perhaps just missing a call to > > pcie_bus_configure_settings()? > > From:

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-09 Thread Arnd Bergmann
On Thursday, June 9, 2016 7:42:24 AM CEST Krzysztof Hałasa wrote: > Arnd Bergmann writes: > > > What exactly is the problem we are seeing, and is there a way to fix > > it on top of my patch? Are we perhaps just missing a call to > > pcie_bus_configure_settings()? > > From: khal...@piap.pl

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-08 Thread Krzysztof Hałasa
Arnd Bergmann writes: > What exactly is the problem we are seeing, and is there a way to fix > it on top of my patch? Are we perhaps just missing a call to > pcie_bus_configure_settings()? From: khal...@piap.pl (Krzysztof Halasa) Subject: [PATCH] Extend PCIE_BUS_PEER2PEER to set

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-08 Thread Krzysztof Hałasa
Arnd Bergmann writes: > What exactly is the problem we are seeing, and is there a way to fix > it on top of my patch? Are we perhaps just missing a call to > pcie_bus_configure_settings()? From: khal...@piap.pl (Krzysztof Halasa) Subject: [PATCH] Extend PCIE_BUS_PEER2PEER to set MRSS=128 to fix

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-01 Thread Arnd Bergmann
On Wednesday, June 1, 2016 1:08:59 PM CEST Krzysztof Hałasa wrote: > Bjorn Helgaas writes: > > > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > > GW-2388) because the MRRS

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-01 Thread Arnd Bergmann
On Wednesday, June 1, 2016 1:08:59 PM CEST Krzysztof Hałasa wrote: > Bjorn Helgaas writes: > > > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > > GW-2388) because the MRRS setting is never written to

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-01 Thread Krzysztof Hałasa
Bjorn Helgaas writes: > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > GW-2388) because the MRRS setting is never written to the hardware. > > Signed-off-by: Bjorn Helgaas

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-06-01 Thread Krzysztof Hałasa
Bjorn Helgaas writes: > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > GW-2388) because the MRRS setting is never written to the hardware. > > Signed-off-by: Bjorn Helgaas > CC: Arnd Bergmann > CC:

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-05-31 Thread Bjorn Helgaas
[+cc Russell, linux-arm-kernel] On Tue, May 31, 2016 at 04:58:02PM -0500, Bjorn Helgaas wrote: > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > GW-2388) because the MRRS setting is never written to the

Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-05-31 Thread Bjorn Helgaas
[+cc Russell, linux-arm-kernel] On Tue, May 31, 2016 at 04:58:02PM -0500, Bjorn Helgaas wrote: > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > GW-2388) because the MRRS setting is never written to the

[PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-05-31 Thread Bjorn Helgaas
This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna GW-2388) because the MRRS setting is never written to the hardware. Signed-off-by: Bjorn Helgaas CC: Arnd Bergmann CC:

[PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"

2016-05-31 Thread Bjorn Helgaas
This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna GW-2388) because the MRRS setting is never written to the hardware. Signed-off-by: Bjorn Helgaas CC: Arnd Bergmann CC: Krzysztof Hałasa ---