Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-24 Thread Tejun Heo
On Tue, Jul 17, 2018 at 10:49:35AM +, Corentin Labbe wrote: > Since ahci_platform_put_resources() use target_pwrs after "devm_" freed > it, we cannot use devm_kcalloc for allocating target_pwrs. > > This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. > > Reported-by: Mikko

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-24 Thread Tejun Heo
On Tue, Jul 17, 2018 at 10:49:35AM +, Corentin Labbe wrote: > Since ahci_platform_put_resources() use target_pwrs after "devm_" freed > it, we cannot use devm_kcalloc for allocating target_pwrs. > > This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. > > Reported-by: Mikko

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-24 Thread Jon Hunter
On 18/07/18 07:30, Marcel Ziswiler wrote: > On Tue, 2018-07-17 at 13:57 +0300, Mikko Perttunen wrote: >> Thanks! > > Yes, that fixes Apalis TK1 crashing as of late as well. > >> Reviewed-by: Mikko Perttunen > > Tested-by: Marcel Ziswiler Tested-by: Jon Hunter Can someone pick this up?

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-24 Thread Jon Hunter
On 18/07/18 07:30, Marcel Ziswiler wrote: > On Tue, 2018-07-17 at 13:57 +0300, Mikko Perttunen wrote: >> Thanks! > > Yes, that fixes Apalis TK1 crashing as of late as well. > >> Reviewed-by: Mikko Perttunen > > Tested-by: Marcel Ziswiler Tested-by: Jon Hunter Can someone pick this up?

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-18 Thread Marcel Ziswiler
On Tue, 2018-07-17 at 13:57 +0300, Mikko Perttunen wrote: > Thanks! Yes, that fixes Apalis TK1 crashing as of late as well. > Reviewed-by: Mikko Perttunen Tested-by: Marcel Ziswiler > On 17.07.2018 13:49, Corentin Labbe wrote: > > Since ahci_platform_put_resources() use target_pwrs after

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-18 Thread Marcel Ziswiler
On Tue, 2018-07-17 at 13:57 +0300, Mikko Perttunen wrote: > Thanks! Yes, that fixes Apalis TK1 crashing as of late as well. > Reviewed-by: Mikko Perttunen Tested-by: Marcel Ziswiler > On 17.07.2018 13:49, Corentin Labbe wrote: > > Since ahci_platform_put_resources() use target_pwrs after

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-17 Thread Mikko Perttunen
Thanks! Reviewed-by: Mikko Perttunen On 17.07.2018 13:49, Corentin Labbe wrote: Since ahci_platform_put_resources() use target_pwrs after "devm_" freed it, we cannot use devm_kcalloc for allocating target_pwrs. This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. Reported-by: Mikko

Re: [PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-17 Thread Mikko Perttunen
Thanks! Reviewed-by: Mikko Perttunen On 17.07.2018 13:49, Corentin Labbe wrote: Since ahci_platform_put_resources() use target_pwrs after "devm_" freed it, we cannot use devm_kcalloc for allocating target_pwrs. This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. Reported-by: Mikko

[PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-17 Thread Corentin Labbe
Since ahci_platform_put_resources() use target_pwrs after "devm_" freed it, we cannot use devm_kcalloc for allocating target_pwrs. This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. Reported-by: Mikko Perttunen Signed-off-by: Corentin Labbe --- drivers/ata/libahci_platform.c | 8

[PATCH] Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-17 Thread Corentin Labbe
Since ahci_platform_put_resources() use target_pwrs after "devm_" freed it, we cannot use devm_kcalloc for allocating target_pwrs. This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. Reported-by: Mikko Perttunen Signed-off-by: Corentin Labbe --- drivers/ata/libahci_platform.c | 8