Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-07 Thread Gabriele Mazzotta
On 07/08/2018 23:22, Srinivas Pandruvada wrote: > On Tue, 2018-08-07 at 22:12 +0200, Gabriele Mazzotta wrote: >> On 07/08/2018 00:11, Srinivas Pandruvada wrote: >>> On Mon, 2018-08-06 at 23:50 +0200, Gabriele Mazzotta wrote: On 06/08/2018 18:49, Srinivas Pandruvada wrote: > On Mon, 2018-08

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-07 Thread Srinivas Pandruvada
On Tue, 2018-08-07 at 22:12 +0200, Gabriele Mazzotta wrote: > On 07/08/2018 00:11, Srinivas Pandruvada wrote: > > On Mon, 2018-08-06 at 23:50 +0200, Gabriele Mazzotta wrote: > > > On 06/08/2018 18:49, Srinivas Pandruvada wrote: > > > > On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: > >

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-07 Thread Gabriele Mazzotta
On 07/08/2018 00:11, Srinivas Pandruvada wrote: > On Mon, 2018-08-06 at 23:50 +0200, Gabriele Mazzotta wrote: >> On 06/08/2018 18:49, Srinivas Pandruvada wrote: >>> On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: On Sat, Aug 4, 2018 at 7:31 PM, Gabriele Mazzotta wrote: >

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-06 Thread Srinivas Pandruvada
On Mon, 2018-08-06 at 23:50 +0200, Gabriele Mazzotta wrote: > On 06/08/2018 18:49, Srinivas Pandruvada wrote: > > On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: > > > On Sat, Aug 4, 2018 at 7:31 PM, Gabriele Mazzotta > > > wrote: > > > > On 04/08/2018 17:29, Gabriele Mazzotta wrote: >

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-06 Thread Gabriele Mazzotta
On 06/08/2018 18:49, Srinivas Pandruvada wrote: > On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: >> On Sat, Aug 4, 2018 at 7:31 PM, Gabriele Mazzotta >> wrote: >>> On 04/08/2018 17:29, Gabriele Mazzotta wrote: This change does not take into account that some BIOSes change MS

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-06 Thread Srinivas Pandruvada
On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: > On Sat, Aug 4, 2018 at 7:31 PM, Gabriele Mazzotta > wrote: > > On 04/08/2018 17:29, Gabriele Mazzotta wrote: > > > This change does not take into account that some BIOSes change > > > MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-06 Thread Rafael J. Wysocki
On Sat, Aug 4, 2018 at 7:31 PM, Gabriele Mazzotta wrote: > On 04/08/2018 17:29, Gabriele Mazzotta wrote: >> This change does not take into account that some BIOSes change >> MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the power source. >> If the turbo is disabled when the system boots, policy.

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-04 Thread Gabriele Mazzotta
On 04/08/2018 17:29, Gabriele Mazzotta wrote: > This change does not take into account that some BIOSes change > MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the power source. > If the turbo is disabled when the system boots, policy.max_freq > is set to pstate.max_pstate. However, if the BIOS la

[PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-04 Thread Gabriele Mazzotta
This change does not take into account that some BIOSes change MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the power source. If the turbo is disabled when the system boots, policy.max_freq is set to pstate.max_pstate. However, if the BIOS later enables the turbo, the CPU will never be able to r