Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
On Wed, 10 Feb 2021 04:47:34 PST (-0800), sch...@linux-m68k.org wrote: On Feb 04 2021, Palmer Dabbelt wrote: From: Palmer Dabbelt VSC8541 phys need a special reset sequence, which the driver doesn't currentlny support. As a result enabling the reset via GPIO essentially guarnteees that the device won't work correctly. This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset") Cc: sta...@vger.kernel.org Signed-off-by: Palmer Dabbelt This fixes ethernet on the HiFive Unleashed with 5.10.12. Thanks for testing. Looks like I forgot to reply, but it's in Linus' tree and should end up in stable.
Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
On Feb 04 2021, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > VSC8541 phys need a special reset sequence, which the driver doesn't > currentlny support. As a result enabling the reset via GPIO essentially > guarnteees that the device won't work correctly. > > This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. > > Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy > reset") > Cc: sta...@vger.kernel.org > Signed-off-by: Palmer Dabbelt This fixes ethernet on the HiFive Unleashed with 5.10.12. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
[PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"
From: Palmer Dabbelt VSC8541 phys need a special reset sequence, which the driver doesn't currentlny support. As a result enabling the reset via GPIO essentially guarnteees that the device won't work correctly. This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset") Cc: sta...@vger.kernel.org Signed-off-by: Palmer Dabbelt --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts index 24d75a146e02..60846e88ae4b 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -90,7 +90,6 @@ { phy0: ethernet-phy@0 { compatible = "ethernet-phy-id0007.0771"; reg = <0>; - reset-gpios = < 12 GPIO_ACTIVE_LOW>; }; }; -- 2.30.0.478.g8a0d178c01-goog