Re: [PATCH] Revert "kbuild: use -Oz instead of -Os when using clang"

2019-03-20 Thread Masahiro Yamada
On Tue, Mar 19, 2019 at 6:10 AM Matthias Kaehlcke wrote: > > The clang option -Oz enables *aggressive* optimization for size, > which doesn't necessarily result in smaller images, but can have > negative impact on performance. Switch back to the less aggressive > -Os. > > This reverts commit

Re: [PATCH] Revert "kbuild: use -Oz instead of -Os when using clang"

2019-03-18 Thread Nick Desaulniers
On Mon, Mar 18, 2019 at 3:07 PM wrote: > > On March 18, 2019 2:56:05 PM PDT, Matthias Kaehlcke wrote: > >> > KBUILD_CFLAGS += $(call cc-disable-warning, int-in-bool-context) > >> > > >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > >> > -KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) > >> >

Re: [PATCH] Revert "kbuild: use -Oz instead of -Os when using clang"

2019-03-18 Thread hpa
On March 18, 2019 2:56:05 PM PDT, Matthias Kaehlcke wrote: >On Mon, Mar 18, 2019 at 02:47:13PM -0700, 'Nick Desaulniers' via Clang >Built Linux wrote: >> On Mon, Mar 18, 2019 at 2:10 PM Matthias Kaehlcke >wrote: >> > >> > The clang option -Oz enables *aggressive* optimization for size, >> >

Re: [PATCH] Revert "kbuild: use -Oz instead of -Os when using clang"

2019-03-18 Thread Matthias Kaehlcke
On Mon, Mar 18, 2019 at 02:47:13PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > On Mon, Mar 18, 2019 at 2:10 PM Matthias Kaehlcke wrote: > > > > The clang option -Oz enables *aggressive* optimization for size, > > which doesn't necessarily result in smaller images, but can have > >

Re: [PATCH] Revert "kbuild: use -Oz instead of -Os when using clang"

2019-03-18 Thread Nick Desaulniers
On Mon, Mar 18, 2019 at 2:10 PM Matthias Kaehlcke wrote: > > The clang option -Oz enables *aggressive* optimization for size, > which doesn't necessarily result in smaller images, but can have > negative impact on performance. Switch back to the less aggressive > -Os. > > This reverts commit

[PATCH] Revert "kbuild: use -Oz instead of -Os when using clang"

2019-03-18 Thread Matthias Kaehlcke
The clang option -Oz enables *aggressive* optimization for size, which doesn't necessarily result in smaller images, but can have negative impact on performance. Switch back to the less aggressive -Os. This reverts commit 6748cb3c299de1ffbe56733647b01dbcc398c419. Suggested-by: Peter Zijlstra