Re: [PATCH] Revert "mfd: cros_ec: Use devm_kzalloc for private data"

2018-12-05 Thread Lee Jones
On Tue, 04 Dec 2018, Enric Balletbo i Serra wrote: > This reverts commit 3aa2177e47878f7e7616da8a2050c44f22301b6e. > > That commit triggered a new WARN when unloading the module (see at the > end of the commit message). When a class_dev is embedded in a structure > then that class_dev is the thin

Re: [PATCH] Revert "mfd: cros_ec: Use devm_kzalloc for private data"

2018-12-04 Thread Dmitry Torokhov
On Tue, Dec 4, 2018 at 8:07 AM Guenter Roeck wrote: > > On Tue, Dec 4, 2018 at 7:58 AM Enric Balletbo i Serra > wrote: > > > > This reverts commit 3aa2177e47878f7e7616da8a2050c44f22301b6e. > > > > That commit triggered a new WARN when unloading the module (see at the > > end of the commit message

Re: [PATCH] Revert "mfd: cros_ec: Use devm_kzalloc for private data"

2018-12-04 Thread Guenter Roeck
On Tue, Dec 4, 2018 at 7:58 AM Enric Balletbo i Serra wrote: > > This reverts commit 3aa2177e47878f7e7616da8a2050c44f22301b6e. > > That commit triggered a new WARN when unloading the module (see at the > end of the commit message). When a class_dev is embedded in a structure > then that class_dev

[PATCH] Revert "mfd: cros_ec: Use devm_kzalloc for private data"

2018-12-04 Thread Enric Balletbo i Serra
This reverts commit 3aa2177e47878f7e7616da8a2050c44f22301b6e. That commit triggered a new WARN when unloading the module (see at the end of the commit message). When a class_dev is embedded in a structure then that class_dev is the thing that controls the lifetime of that structure, for that reaso