Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-22 Thread Pekka Enberg
Hi Thomas, On Dec 5, 2007 11:25 AM, Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > > These: > > > > > +#define READ_SC(p, r)readb((p)->membase + RD_##r) > > > +#define WRITE_SC(p, r, v)writeb((v), (p)->membase + WR_##r) > > > > and these: > > > > > +#define READ_SC_PORT(p, r)

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-22 Thread Pekka Enberg
Hi Thomas, On Dec 5, 2007 11:25 AM, Thomas Bogendoerfer [EMAIL PROTECTED] wrote: These: +#define READ_SC(p, r)readb((p)-membase + RD_##r) +#define WRITE_SC(p, r, v)writeb((v), (p)-membase + WR_##r) and these: +#define READ_SC_PORT(p, r) read_sc_port(p,

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-21 Thread Andy Whitcroft
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: > > +#define READ_SC(p, r)readb ((p)->membase + RD_##r) > > +#define WRITE_SC(p, r, v)writeb ((v), (p)->membase + WR_##r) > > No space before the (. checkpatch misses this. Yep, over careful in the special case for the

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-21 Thread Andy Whitcroft
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: +#define READ_SC(p, r)readb ((p)-membase + RD_##r) +#define WRITE_SC(p, r, v)writeb ((v), (p)-membase + WR_##r) No space before the (. checkpatch misses this. Yep, over careful in the special case for the

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-05 Thread Thomas Bogendoerfer
On Tue, Dec 04, 2007 at 07:27:38PM -0800, Andrew Morton wrote: > grumble. > > These: > > > +#define READ_SC(p, r)readb((p)->membase + RD_##r) > > +#define WRITE_SC(p, r, v)writeb((v), (p)->membase + WR_##r) > > and these: > > > +#define READ_SC_PORT(p, r) read_sc_port(p,

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-05 Thread Thomas Bogendoerfer
On Tue, Dec 04, 2007 at 07:27:38PM -0800, Andrew Morton wrote: grumble. These: +#define READ_SC(p, r)readb((p)-membase + RD_##r) +#define WRITE_SC(p, r, v)writeb((v), (p)-membase + WR_##r) and these: +#define READ_SC_PORT(p, r) read_sc_port(p, RD_PORT_##r)

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Andrew Morton
On Wed, 5 Dec 2007 00:41:12 +0100 [EMAIL PROTECTED] (Thomas Bogendoerfer) wrote: > On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: > > On Sun, 2 Dec 2007 20:43:46 +0100 (CET) > > Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > > > > > New serial driver for SC2681/SC2691 uarts.

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Thomas Bogendoerfer
On Tue, Dec 04, 2007 at 12:45:16PM +, Alan Cox wrote: > > I tried to numbers several months ago and didn't get any response > > Please raise it with the relevant people. If our LANANA administrator is > not doing their job then the Linuxfoundation need to find a replacement, > or hand

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Thomas Bogendoerfer
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: > On Sun, 2 Dec 2007 20:43:46 +0100 (CET) > Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > > > New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are > > using these chips for onboard serial ports. > > > > Little

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Alan Cox
On Tue, 4 Dec 2007 09:25:35 +0100 [EMAIL PROTECTED] (Thomas Bogendoerfer) wrote: > On Mon, Dec 03, 2007 at 03:57:46PM -0800, Arjan van de Ven wrote: > > > > +#define SC26XX_MAJOR 204 > > > > +#define SC26XX_MINOR_START 205 > > > > +#define SC26XX_NR2 > > > > did lanana

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Geert Uytterhoeven
On Tue, 4 Dec 2007, Thomas Bogendoerfer wrote: > On Mon, Dec 03, 2007 at 03:57:46PM -0800, Arjan van de Ven wrote: > > > > +#define SC26XX_MAJOR 204 > > > > +#define SC26XX_MINOR_START 205 > > > > +#define SC26XX_NR2 > > > > did lanana assign these numbers officially? > > I

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Thomas Bogendoerfer
On Mon, Dec 03, 2007 at 03:57:46PM -0800, Arjan van de Ven wrote: > > > +#define SC26XX_MAJOR 204 > > > +#define SC26XX_MINOR_START 205 > > > +#define SC26XX_NR2 > > did lanana assign these numbers officially? I tried to numbers several months ago and didn't get any

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Thomas Bogendoerfer
On Mon, Dec 03, 2007 at 03:57:46PM -0800, Arjan van de Ven wrote: +#define SC26XX_MAJOR 204 +#define SC26XX_MINOR_START 205 +#define SC26XX_NR2 did lanana assign these numbers officially? I tried to numbers several months ago and didn't get any response :-(

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Geert Uytterhoeven
On Tue, 4 Dec 2007, Thomas Bogendoerfer wrote: On Mon, Dec 03, 2007 at 03:57:46PM -0800, Arjan van de Ven wrote: +#define SC26XX_MAJOR 204 +#define SC26XX_MINOR_START 205 +#define SC26XX_NR2 did lanana assign these numbers officially? I tried to numbers

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Alan Cox
On Tue, 4 Dec 2007 09:25:35 +0100 [EMAIL PROTECTED] (Thomas Bogendoerfer) wrote: On Mon, Dec 03, 2007 at 03:57:46PM -0800, Arjan van de Ven wrote: +#define SC26XX_MAJOR 204 +#define SC26XX_MINOR_START 205 +#define SC26XX_NR2 did lanana assign these numbers

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Thomas Bogendoerfer
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: On Sun, 2 Dec 2007 20:43:46 +0100 (CET) Thomas Bogendoerfer [EMAIL PROTECTED] wrote: New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are using these chips for onboard serial ports. Little things...

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Thomas Bogendoerfer
On Tue, Dec 04, 2007 at 12:45:16PM +, Alan Cox wrote: I tried to numbers several months ago and didn't get any response Please raise it with the relevant people. If our LANANA administrator is not doing their job then the Linuxfoundation need to find a replacement, or hand control of

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-04 Thread Andrew Morton
On Wed, 5 Dec 2007 00:41:12 +0100 [EMAIL PROTECTED] (Thomas Bogendoerfer) wrote: On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote: On Sun, 2 Dec 2007 20:43:46 +0100 (CET) Thomas Bogendoerfer [EMAIL PROTECTED] wrote: New serial driver for SC2681/SC2691 uarts. Older SNI

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-03 Thread Arjan van de Ven
On Mon, 3 Dec 2007 15:53:17 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 2 Dec 2007 20:43:46 +0100 (CET) > Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > > > New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines > > are using these chips for onboard serial ports. > >

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-03 Thread Andrew Morton
On Sun, 2 Dec 2007 20:43:46 +0100 (CET) Thomas Bogendoerfer <[EMAIL PROTECTED]> wrote: > New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are > using these chips for onboard serial ports. > Little things... > --- /dev/null > +++ b/drivers/serial/sc26xx.c > @@ -0,0 +1,757 @@

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-03 Thread Arjan van de Ven
On Mon, 3 Dec 2007 15:53:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 2 Dec 2007 20:43:46 +0100 (CET) Thomas Bogendoerfer [EMAIL PROTECTED] wrote: New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are using these chips for onboard serial ports. Little

Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-03 Thread Andrew Morton
On Sun, 2 Dec 2007 20:43:46 +0100 (CET) Thomas Bogendoerfer [EMAIL PROTECTED] wrote: New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are using these chips for onboard serial ports. Little things... --- /dev/null +++ b/drivers/serial/sc26xx.c @@ -0,0 +1,757 @@ +/* +

[PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-02 Thread Thomas Bogendoerfer
New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are using these chips for onboard serial ports. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Please apply for 2.6.25. drivers/serial/Kconfig | 15 + drivers/serial/Makefile |1 + drivers/serial/sc26xx.c |

[PATCH] SC26XX: New serial driver for SC2681 uarts

2007-12-02 Thread Thomas Bogendoerfer
New serial driver for SC2681/SC2691 uarts. Older SNI RM400 machines are using these chips for onboard serial ports. Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED] --- Please apply for 2.6.25. drivers/serial/Kconfig | 15 + drivers/serial/Makefile |1 + drivers/serial/sc26xx.c |