Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Boaz Harrosh
On 04/02/2015 12:30 PM, Christoph Hellwig wrote: > On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote: >> pfn = PFN_DOWN(ei->addr + ei->size); >> >> -switch (ei->type) { >> -case E820_RAM: >> -case E820_PRAM: >> -case

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 11:37:40AM +0200, Ingo Molnar wrote: > So assuming this works on your test setup Boaz's changes work fine here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 11:37:40AM +0200, Ingo Molnar wrote: > So assuming this works on your test setup I'm inclined to squash > Boaz's fixes into the original patch, assuming you see no outright bug > in them. Anything else can be done as delta improvements. It looks sensible, but I'd really

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Ingo Molnar
* Christoph Hellwig wrote: > On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote: > > pfn = PFN_DOWN(ei->addr + ei->size); > > > > - switch (ei->type) { > > - case E820_RAM: > > - case E820_PRAM: > > - case E820_RESERVED_KERN: > > -

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Christoph Hellwig
On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote: > pfn = PFN_DOWN(ei->addr + ei->size); > > - switch (ei->type) { > - case E820_RAM: > - case E820_PRAM: > - case E820_RESERVED_KERN: > - break; > -

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Ingo Molnar
* Christoph Hellwig h...@lst.de wrote: On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote: pfn = PFN_DOWN(ei-addr + ei-size); - switch (ei-type) { - case E820_RAM: - case E820_PRAM: - case E820_RESERVED_KERN: -

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 11:37:40AM +0200, Ingo Molnar wrote: So assuming this works on your test setup I'm inclined to squash Boaz's fixes into the original patch, assuming you see no outright bug in them. Anything else can be done as delta improvements. It looks sensible, but I'd really

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Christoph Hellwig
On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote: pfn = PFN_DOWN(ei-addr + ei-size); - switch (ei-type) { - case E820_RAM: - case E820_PRAM: - case E820_RESERVED_KERN: - break; -

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Boaz Harrosh
On 04/02/2015 12:30 PM, Christoph Hellwig wrote: On Wed, Apr 01, 2015 at 05:25:22PM +0300, Boaz Harrosh wrote: pfn = PFN_DOWN(ei-addr + ei-size); -switch (ei-type) { -case E820_RAM: -case E820_PRAM: -case E820_RESERVED_KERN: -

Re: [PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 11:37:40AM +0200, Ingo Molnar wrote: So assuming this works on your test setup Boaz's changes work fine here. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-01 Thread Boaz Harrosh
Finally with these fixes I'm able to define memmap=! regions in NUMA machines. Any combination cross or not cross NUMA boundary. And not only the memmap=! regions had problems also the real type-12 NvDIMMs had the same NUMA problems. Now it all works. Also I have kept the "don't merge PRAM"

[PATCH] SQUASHME: Fixes to e820 handling of pmem

2015-04-01 Thread Boaz Harrosh
Finally with these fixes I'm able to define memmap=! regions in NUMA machines. Any combination cross or not cross NUMA boundary. And not only the memmap=! regions had problems also the real type-12 NvDIMMs had the same NUMA problems. Now it all works. Also I have kept the don't merge PRAM