Re: [PATCH] Staging: android: fixed permissions style issue

[Joe Perches]

On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote:
> Fixed a coding style issue. Changed symbolic permissions to octal.

If you do these, please shorten the lines where possible.

> diff --git a/drivers/staging/android/lowmemorykiller.c 
> b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
>   * not really modular, but the easiest way to keep compat with existing
>   * bootargs behaviour is to continue using module_param here.
>   */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
>  module_param_array_named(adj, lowmem_adj, short, _adj_size,
> -  S_IRUGO | S_IWUSR);
> +  0644);

module_param_array_named(adj, lowmem_adj, short, _adj_size, 0644);

etc...

Re: [PATCH] Staging: android: fixed permissions style issue

[Joe Perches]

On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote:
> Fixed a coding style issue. Changed symbolic permissions to octal.

If you do these, please shorten the lines where possible.

> diff --git a/drivers/staging/android/lowmemorykiller.c 
> b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
>   * not really modular, but the easiest way to keep compat with existing
>   * bootargs behaviour is to continue using module_param here.
>   */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
>  module_param_array_named(adj, lowmem_adj, short, _adj_size,
> -  S_IRUGO | S_IWUSR);
> +  0644);

module_param_array_named(adj, lowmem_adj, short, _adj_size, 0644);

etc...

[PATCH] Staging: android: fixed permissions style issue

[Eric Salem]

Fixed a coding style issue. Changed symbolic permissions to octal.

Signed-off-by: Eric Salem 
---
 drivers/staging/android/lowmemorykiller.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/lowmemorykiller.c 
b/drivers/staging/android/lowmemorykiller.c
index 80d7adf..553a3ee 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -204,10 +204,10 @@ device_initcall(lowmem_init);
  * not really modular, but the easiest way to keep compat with existing
  * bootargs behaviour is to continue using module_param here.
  */
-module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
+module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
 module_param_array_named(adj, lowmem_adj, short, _adj_size,
-S_IRUGO | S_IWUSR);
+0644);
 module_param_array_named(minfree, lowmem_minfree, uint, _minfree_size,
-S_IRUGO | S_IWUSR);
-module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
+0644);
+module_param_named(debug_level, lowmem_debug_level, uint, 0644);
 
-- 
2.7.4

[PATCH] Staging: android: fixed permissions style issue

[Eric Salem]

Fixed a coding style issue. Changed symbolic permissions to octal.

Signed-off-by: Eric Salem 
---
 drivers/staging/android/lowmemorykiller.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/lowmemorykiller.c 
b/drivers/staging/android/lowmemorykiller.c
index 80d7adf..553a3ee 100644
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -204,10 +204,10 @@ device_initcall(lowmem_init);
  * not really modular, but the easiest way to keep compat with existing
  * bootargs behaviour is to continue using module_param here.
  */
-module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
+module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
 module_param_array_named(adj, lowmem_adj, short, _adj_size,
-S_IRUGO | S_IWUSR);
+0644);
 module_param_array_named(minfree, lowmem_minfree, uint, _minfree_size,
-S_IRUGO | S_IWUSR);
-module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
+0644);
+module_param_named(debug_level, lowmem_debug_level, uint, 0644);
 
-- 
2.7.4