Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Srishti Sharma wrote: > >> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter >> wrote: >> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> >> Again, you

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Srishti Sharma wrote: > >> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter >> wrote: >> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> >> Again, you have three patches on different files with the

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, 4 Oct 2017, Srishti Sharma wrote: > On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter > wrote: > > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: > >> Again, you have three patches on different files with the same subject > >> line. You could add

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, 4 Oct 2017, Srishti Sharma wrote: > On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter > wrote: > > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: > >> Again, you have three patches on different files with the same subject > >> line. You could add the file name eg rtw_ap:

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> Again, you have three patches on different files with the same subject >> line. You could add the file name eg rtw_ap: to the subject line to make >>

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> Again, you have three patches on different files with the same subject >> line. You could add the file name eg rtw_ap: to the subject line to make >> them unique. >> > > And

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: > Again, you have three patches on different files with the same subject > line. You could add the file name eg rtw_ap: to the subject line to make > them unique. > And the subject needs to start with [PATCH v3] and then after the

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: > Again, you have three patches on different files with the same subject > line. You could add the file name eg rtw_ap: to the subject line to make > them unique. > And the subject needs to start with [PATCH v3] and then after the

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:11 PM, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > >> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: >> > >> > >> > On Wed, 4 Oct 2017, Dan Carpenter wrote: >> > >> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530,

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:11 PM, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > >> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: >> > >> > >> > On Wed, 4 Oct 2017, Dan Carpenter wrote: >> > >> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: > > > > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > > > > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > > > Use list_for_each_entry_safe when the list elements may

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: > > > > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > > > > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > > > Use list_for_each_entry_safe when the list elements may

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > > Use list_for_each_entry_safe when the list elements may get deleted > > > during traversal. > > > > This patch

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > > Use list_for_each_entry_safe when the list elements may get deleted > > > during traversal. > > > > This patch

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > Use list_for_each_entry_safe when the list elements may get deleted > > during traversal. > > This patch is fine as a cleanup but none of these are actually buggy. I'm not sure what

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > Use list_for_each_entry_safe when the list elements may get deleted > > during traversal. > > This patch is fine as a cleanup but none of these are actually buggy. I'm not sure what

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Again, you have three patches on different files with the same subject line. You could add the file name eg rtw_ap: to the subject line to make them unique. julia On Wed, 4 Oct 2017, Srishti Sharma wrote: > Use list_for_each_entry_safe to make the code more compact. Done > by the following

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Again, you have three patches on different files with the same subject line. You could add the file name eg rtw_ap: to the subject line to make them unique. julia On Wed, 4 Oct 2017, Srishti Sharma wrote: > Use list_for_each_entry_safe to make the code more compact. Done > by the following

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe to make the code more compact. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m, list_del_init, f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe to make the code more compact. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m, list_del_init, f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe to make code more compact. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe to make code more compact. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe to make the code more compact. Done by the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe to make the code more compact. Done by the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m,list_del_init,f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...)

Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > Use list_for_each_entry_safe when the list elements may get deleted > during traversal. This patch is fine as a cleanup but none of these are actually buggy. regards, dan carpenter

Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > Use list_for_each_entry_safe when the list elements may get deleted > during traversal. This patch is fine as a cleanup but none of these are actually buggy. regards, dan carpenter

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe when the list elements may get deleted during traversal. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m, list_del_init, f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; ...

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

Use list_for_each_entry_safe when the list elements may get deleted during traversal. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; expression e; identifier m, list_del_init, f; type T1; T1* pos; iterator name list_for_each_entry_safe; @@ f(...){ +T1* tmp; ...