Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

2017-03-04 Thread Julian Calaby 
Hi All,

On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil  wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil 

Again, I'm dubious if this is needed or helpful, but

Reviewed-by: Julian Calaby 

> ---
>  drivers/staging/wilc1000/linux_wlan.c | 11 +++
>  1 file changed, 3 insertions(+), 8 deletions(-)

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

2017-03-04 Thread Julian Calaby 
Hi All,

On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil  wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil 

Again, I'm dubious if this is needed or helpful, but

Reviewed-by: Julian Calaby 

> ---
>  drivers/staging/wilc1000/linux_wlan.c | 11 +++
>  1 file changed, 3 insertions(+), 8 deletions(-)

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

2017-03-02 Thread Georgios Emmanouil 
Modified the 'if-else' statement to make it more readable.

Signed-off-by: Georgios Emmanouil 
---
 drivers/staging/wilc1000/linux_wlan.c | 11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c 
b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..d82f0ff 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -867,15 +867,10 @@ static int wilc_mac_open(struct net_device *ndev)
 wilc_get_vif_idx(vif),
 wl->open_ifcs);
} else {
-   if (memcmp(wl->vif[i ^ 1]->bssid,
-  wl->vif[i ^ 1]->src_addr, 6))
-   wilc_set_wfi_drv_handler(vif,
-wilc_get_vif_idx(vif),
-0);
+   if (memcmp(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 
1]->src_addr, 6))
+   wilc_set_wfi_drv_handler(vif, 
wilc_get_vif_idx(vif), 0);
else
-   wilc_set_wfi_drv_handler(vif,
-wilc_get_vif_idx(vif),
-1);
+   wilc_set_wfi_drv_handler(vif, 
wilc_get_vif_idx(vif), 1);
}
wilc_set_operation_mode(vif, vif->iftype);

--
2.1.4

[PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

2017-03-02 Thread Georgios Emmanouil 
Modified the 'if-else' statement to make it more readable.

Signed-off-by: Georgios Emmanouil 
---
 drivers/staging/wilc1000/linux_wlan.c | 11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c 
b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..d82f0ff 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -867,15 +867,10 @@ static int wilc_mac_open(struct net_device *ndev)
 wilc_get_vif_idx(vif),
 wl->open_ifcs);
} else {
-   if (memcmp(wl->vif[i ^ 1]->bssid,
-  wl->vif[i ^ 1]->src_addr, 6))
-   wilc_set_wfi_drv_handler(vif,
-wilc_get_vif_idx(vif),
-0);
+   if (memcmp(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 
1]->src_addr, 6))
+   wilc_set_wfi_drv_handler(vif, 
wilc_get_vif_idx(vif), 0);
else
-   wilc_set_wfi_drv_handler(vif,
-wilc_get_vif_idx(vif),
-1);
+   wilc_set_wfi_drv_handler(vif, 
wilc_get_vif_idx(vif), 1);
}
wilc_set_operation_mode(vif, vif->iftype);

--
2.1.4