Re: [PATCH] Support resetting WARN*_ONCE

2017-11-03 Thread Michael Ellerman
Andi Kleen writes: > diff --git a/kernel/panic.c b/kernel/panic.c > index bdd18afa19a4..b2d872fa16de 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -587,6 +588,32 @@ void warn_slowpath_null(const char *file, int line) > EXPORT_SYMBOL(warn_slowpath_null); >

Re: [PATCH] Support resetting WARN*_ONCE

2017-11-03 Thread Michael Ellerman
Andi Kleen writes: > diff --git a/kernel/panic.c b/kernel/panic.c > index bdd18afa19a4..b2d872fa16de 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -587,6 +588,32 @@ void warn_slowpath_null(const char *file, int line) > EXPORT_SYMBOL(warn_slowpath_null); > #endif > > +#ifdef

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-19 Thread Andi Kleen
On Wed, Oct 18, 2017 at 04:35:14PM +1100, Michael Ellerman wrote: > Andi Kleen writes: > > > From: Andi Kleen > > > > I like _ONCE warnings because it's guaranteed that they don't > > flood the log. > > > > During testing I find it useful to reset the

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-19 Thread Andi Kleen
On Wed, Oct 18, 2017 at 04:35:14PM +1100, Michael Ellerman wrote: > Andi Kleen writes: > > > From: Andi Kleen > > > > I like _ONCE warnings because it's guaranteed that they don't > > flood the log. > > > > During testing I find it useful to reset the state of the once warnings, > > so that I

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Michael Ellerman
Andi Kleen writes: > From: Andi Kleen > > I like _ONCE warnings because it's guaranteed that they don't > flood the log. > > During testing I find it useful to reset the state of the once warnings, > so that I can rerun tests and see if they trigger

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Michael Ellerman
Andi Kleen writes: > From: Andi Kleen > > I like _ONCE warnings because it's guaranteed that they don't > flood the log. > > During testing I find it useful to reset the state of the once warnings, > so that I can rerun tests and see if they trigger again, or can > guarantee that a test run

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Andi Kleen
> Seems useful. Can we document the new interface please? > > I'm not sure where :( If it was in /proc/sys/kernel then we'd have a > Documentation file. But debugfs? I added a new file Documentation/clearing-warn-once.txt But longer term would be good to document all the debugfs entries

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Andi Kleen
> Seems useful. Can we document the new interface please? > > I'm not sure where :( If it was in /proc/sys/kernel then we'd have a > Documentation file. But debugfs? I added a new file Documentation/clearing-warn-once.txt But longer term would be good to document all the debugfs entries

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Andrew Morton
On Tue, 17 Oct 2017 14:40:17 -0700 Andi Kleen wrote: > From: Andi Kleen > > I like _ONCE warnings because it's guaranteed that they don't > flood the log. > > During testing I find it useful to reset the state of the once warnings, > so that I can

Re: [PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Andrew Morton
On Tue, 17 Oct 2017 14:40:17 -0700 Andi Kleen wrote: > From: Andi Kleen > > I like _ONCE warnings because it's guaranteed that they don't > flood the log. > > During testing I find it useful to reset the state of the once warnings, > so that I can rerun tests and see if they trigger again, or

[PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Andi Kleen
From: Andi Kleen I like _ONCE warnings because it's guaranteed that they don't flood the log. During testing I find it useful to reset the state of the once warnings, so that I can rerun tests and see if they trigger again, or can guarantee that a test run always hits the

[PATCH] Support resetting WARN*_ONCE

2017-10-17 Thread Andi Kleen
From: Andi Kleen I like _ONCE warnings because it's guaranteed that they don't flood the log. During testing I find it useful to reset the state of the once warnings, so that I can rerun tests and see if they trigger again, or can guarantee that a test run always hits the same warnings. This

Re: [PATCH] Support resetting WARN*_ONCE

2016-08-02 Thread kbuild test robot
Hi Andi, [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.7 next-20160802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Support resetting WARN*_ONCE

2016-08-02 Thread kbuild test robot
Hi Andi, [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.7 next-20160802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] Support resetting WARN*_ONCE

2016-08-02 Thread Andi Kleen
From: Andi Kleen WARN*_ONCE warnings only appear once. During testing I find it useful to reset the state of the once warnings, so that I can rerun tests and see if they trigger again, or can guarantee that a test run always hits the same warnings. This patch adds a

[PATCH] Support resetting WARN*_ONCE

2016-08-02 Thread Andi Kleen
From: Andi Kleen WARN*_ONCE warnings only appear once. During testing I find it useful to reset the state of the once warnings, so that I can rerun tests and see if they trigger again, or can guarantee that a test run always hits the same warnings. This patch adds a debugfs interface to reset