Re: [PATCH] Tracing: fix regression of trace_pipe

2013-01-14 Thread Steven Rostedt
On Mon, 2013-01-14 at 10:54 +0800, Liu Bo wrote: > commit 0fb9656d changes the behaviour of trace_pipe, ie. it makes trace_pipe > return if we've read something and tracing is enabled, and this means that > we have to 'cat trace_pipe' again and again while running tests. Bah, this is the second

Re: [PATCH] Tracing: fix regression of trace_pipe

2013-01-14 Thread Steven Rostedt
On Mon, 2013-01-14 at 10:54 +0800, Liu Bo wrote: commit 0fb9656d changes the behaviour of trace_pipe, ie. it makes trace_pipe return if we've read something and tracing is enabled, and this means that we have to 'cat trace_pipe' again and again while running tests. Bah, this is the second

[PATCH] Tracing: fix regression of trace_pipe

2013-01-13 Thread Liu Bo
commit 0fb9656d changes the behaviour of trace_pipe, ie. it makes trace_pipe return if we've read something and tracing is enabled, and this means that we have to 'cat trace_pipe' again and again while running tests. IMO the right way is if tracing is enabled, we always block and wait for ring

[PATCH] Tracing: fix regression of trace_pipe

2013-01-13 Thread Liu Bo
commit 0fb9656d changes the behaviour of trace_pipe, ie. it makes trace_pipe return if we've read something and tracing is enabled, and this means that we have to 'cat trace_pipe' again and again while running tests. IMO the right way is if tracing is enabled, we always block and wait for ring