Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-14 Thread Ashish Sangwan
Hi Jan, > Yeah, I don't think this happens in practice but in theory it could. BTW, > did you check whether we don't need to free other information (like VAT > inode etc.) when rescanning the filesystem? I think we do but currently I'm > catching up after a long vacation and this doesn't have

Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-14 Thread Jan Kara
On Sat 21-07-12 16:35:17, Ashish Sangwan wrote: > If s_lvid_bh is not freed and set to NULL before re-scanning partition > with default block size, we might end up using wrong lvid in case > s_lvid_bh is not updated in udf_load_logicalvolint during rescan. > > Signed-off-by: Ashish Sangwan >

Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-14 Thread Jan Kara
On Sat 21-07-12 16:35:17, Ashish Sangwan wrote: If s_lvid_bh is not freed and set to NULL before re-scanning partition with default block size, we might end up using wrong lvid in case s_lvid_bh is not updated in udf_load_logicalvolint during rescan. Signed-off-by: Ashish Sangwan

Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-14 Thread Ashish Sangwan
Hi Jan, Yeah, I don't think this happens in practice but in theory it could. BTW, did you check whether we don't need to free other information (like VAT inode etc.) when rescanning the filesystem? I think we do but currently I'm catching up after a long vacation and this doesn't have high

Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-11 Thread Namjae Jeon
Hi. Jan. Would you check this patch also ? Thanks. 2012/7/21, Ashish Sangwan : > If s_lvid_bh is not freed and set to NULL before re-scanning partition > with default block size, we might end up using wrong lvid in case > s_lvid_bh is not updated in udf_load_logicalvolint during rescan. > >

Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-11 Thread Namjae Jeon
Hi. Jan. Would you check this patch also ? Thanks. 2012/7/21, Ashish Sangwan ashishsangw...@gmail.com: If s_lvid_bh is not freed and set to NULL before re-scanning partition with default block size, we might end up using wrong lvid in case s_lvid_bh is not updated in udf_load_logicalvolint

[PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-07-21 Thread Ashish Sangwan
If s_lvid_bh is not freed and set to NULL before re-scanning partition with default block size, we might end up using wrong lvid in case s_lvid_bh is not updated in udf_load_logicalvolint during rescan. Signed-off-by: Ashish Sangwan Signed-off-by: Namjae Jeon --- fs/udf/super.c |2 ++ 1

[PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-07-21 Thread Ashish Sangwan
If s_lvid_bh is not freed and set to NULL before re-scanning partition with default block size, we might end up using wrong lvid in case s_lvid_bh is not updated in udf_load_logicalvolint during rescan. Signed-off-by: Ashish Sangwan ashish.sangw...@gmail.com Signed-off-by: Namjae Jeon