On 13.03.2013, at 18:59, Doug Anderson wrote:
> Alexander,
>
> On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf wrote:
>>
+ gpio_free(gpio);
>>>
>>> Freeing the gpio is a little on the iffy side since you actually care
>>> about keeping the value. Perhaps you can change this to
Alexander,
On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf wrote:
>
>>> + gpio_free(gpio);
>>
>> Freeing the gpio is a little on the iffy side since you actually care
>> about keeping the value. Perhaps you can change this to
>> devm_gpio_request_one() and avoid the free? I was about to
On 13.03.2013, at 18:28, Doug Anderson wrote:
> Alexander,
>
> On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf wrote:
>> - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio");
>> - if (err)
>> + /* reset pulls the line down, then up again */
>> + err =
Alexander,
On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf wrote:
> - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio");
> - if (err)
> + /* reset pulls the line down, then up again */
> + err = gpio_request_one(gpio, GPIOF_OUT_INIT_LOW,
On Wed, 13 Mar 2013, Alexander Graf wrote:
> On my Exynos 5 based Arndale system, I need to pull the reset line down
> and then let it go up again to actually perform a reset. Without that
> reset, I can't find any USB hubs on my bus, rendering the USB controller
> useless.
>
> So this patch
On 13.03.2013, at 18:59, Doug Anderson wrote:
Alexander,
On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf ag...@suse.de wrote:
+ gpio_free(gpio);
Freeing the gpio is a little on the iffy side since you actually care
about keeping the value. Perhaps you can change this to
On Wed, 13 Mar 2013, Alexander Graf wrote:
On my Exynos 5 based Arndale system, I need to pull the reset line down
and then let it go up again to actually perform a reset. Without that
reset, I can't find any USB hubs on my bus, rendering the USB controller
useless.
So this patch
Alexander,
On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf ag...@suse.de wrote:
- err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, ehci_vbus_gpio);
- if (err)
+ /* reset pulls the line down, then up again */
+ err = gpio_request_one(gpio, GPIOF_OUT_INIT_LOW,
On 13.03.2013, at 18:28, Doug Anderson wrote:
Alexander,
On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf ag...@suse.de wrote:
- err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, ehci_vbus_gpio);
- if (err)
+ /* reset pulls the line down, then up again */
+ err =
Alexander,
On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf ag...@suse.de wrote:
+ gpio_free(gpio);
Freeing the gpio is a little on the iffy side since you actually care
about keeping the value. Perhaps you can change this to
devm_gpio_request_one() and avoid the free? I was about
On my Exynos 5 based Arndale system, I need to pull the reset line down
and then let it go up again to actually perform a reset. Without that
reset, I can't find any USB hubs on my bus, rendering the USB controller
useless.
So this patch implements the above logic, making EHCI and OHCI work on
On my Exynos 5 based Arndale system, I need to pull the reset line down
and then let it go up again to actually perform a reset. Without that
reset, I can't find any USB hubs on my bus, rendering the USB controller
useless.
So this patch implements the above logic, making EHCI and OHCI work on
12 matches
Mail list logo
