Re: [PATCH] USB: otg: Fix error 32 when enable hardware flow control.

2021-01-11 Thread Johan Hovold
On Mon, Jan 11, 2021 at 04:55:22AM +, Pho Tran wrote: > When hardware flow control is enabled, > don't allow host send MHS command to cp210x. You're commit message needs to explain *why* this is needed (and not just say *what* the patch does). > Signed-off-by: Pho Tran Also fix up the

Re: [PATCH] USB: otg: Fix error 32 when enable hardware flow control.

2021-01-10 Thread gre...@linuxfoundation.org
On Mon, Jan 11, 2021 at 04:55:22AM +, Pho Tran wrote: > When hardware flow control is enabled, > don't allow host send MHS command to cp210x. > > Signed-off-by: Pho Tran Nit, you need a ' ' before the '<' character. And why didn't you send this to the maintainer of this file as described by

[PATCH] USB: otg: Fix error 32 when enable hardware flow control.

2021-01-10 Thread Pho Tran
When hardware flow control is enabled, don't allow host send MHS command to cp210x. Signed-off-by: Pho Tran --- drivers/usb/serial/cp210x.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/cp210x.c