Re: [PATCH] Use ctlr directly in rdac_failover_get()

2017-05-19 Thread Bart Van Assche
On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote: > rdac_failover_get references struct rdac_controller as > ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being > inefficient this also introduces a null-pointer dereference as > send_mode_select() sets ctlr->ms_sdev to NULL

Re: [PATCH] Use ctlr directly in rdac_failover_get()

2017-05-19 Thread Bart Van Assche
On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote: > rdac_failover_get references struct rdac_controller as > ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being > inefficient this also introduces a null-pointer dereference as > send_mode_select() sets ctlr->ms_sdev to NULL

[PATCH] Use ctlr directly in rdac_failover_get()

2017-05-19 Thread Artem Savkov
rdac_failover_get references struct rdac_controller as ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being inefficient this also introduces a null-pointer dereference as send_mode_select() sets ctlr->ms_sdev to NULL before calling rdac_failover_get(): [ 18.432550]

[PATCH] Use ctlr directly in rdac_failover_get()

2017-05-19 Thread Artem Savkov
rdac_failover_get references struct rdac_controller as ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being inefficient this also introduces a null-pointer dereference as send_mode_select() sets ctlr->ms_sdev to NULL before calling rdac_failover_get(): [ 18.432550]