Re: [PATCH] Use on-board instead of built-in in config options

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Frans Pop wrote:
> On Saturday 26 January 2008, Bartlomiej Zolnierkiewicz wrote:
> > On Saturday 26 January 2008, Jan Engelhardt wrote:
> > > On Jan 26 2008 21:31, Frans Pop wrote:
> > > >>  config BLK_DEV_IDE_PMAC
> > > >> -   bool "Builtin PowerMac IDE support"
> > > >> +   tristate "Builtin PowerMac IDE support"
> >
> > this change is no-op at the moment because the next Kconfig line is:
> >
> > depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
> >
> > [ PPC-specific IDE host drivers are still a special case because they are
> >   using ppc_ide_md architecture hooks instead of doing proper host driver
> >   initialization sequence - to be fixed after adding warm-plug support...
> > ]
> >
> > > >This does not seem to make sense: if the option is now tristate, it is
> > > > no longer "Builtin", so probably s/Builtin // in the description.
> > >
> > > Or something like s/Builtin/Onboard/;
> 
> I did not even consider that meaning of built-in, but that does seem more 
> descriptive.
> 
> > Please send a patch.
> 
> Of course :-)
> 
> ---
> From: Frans Pop <[EMAIL PROTECTED]>
> 
> To avoid confusion between 'built-in' drivers and 'on-board'
> controllers, consistently use the term 'on-board' for controllers.
> 
> Minor line-wrapping improvements in descriptions for config options.
> 
> Signed-off-by: Frans Pop <[EMAIL PROTECTED]>

applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] Use on-board instead of built-in in config options

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Frans Pop wrote:
 On Saturday 26 January 2008, Bartlomiej Zolnierkiewicz wrote:
  On Saturday 26 January 2008, Jan Engelhardt wrote:
   On Jan 26 2008 21:31, Frans Pop wrote:
 config BLK_DEV_IDE_PMAC
-   bool Builtin PowerMac IDE support
+   tristate Builtin PowerMac IDE support
 
  this change is no-op at the moment because the next Kconfig line is:
 
  depends on PPC_PMAC  IDE=y  BLK_DEV_IDE=y
 
  [ PPC-specific IDE host drivers are still a special case because they are
using ppc_ide_md architecture hooks instead of doing proper host driver
initialization sequence - to be fixed after adding warm-plug support...
  ]
 
   This does not seem to make sense: if the option is now tristate, it is
no longer Builtin, so probably s/Builtin // in the description.
  
   Or something like s/Builtin/Onboard/;
 
 I did not even consider that meaning of built-in, but that does seem more 
 descriptive.
 
  Please send a patch.
 
 Of course :-)
 
 ---
 From: Frans Pop [EMAIL PROTECTED]
 
 To avoid confusion between 'built-in' drivers and 'on-board'
 controllers, consistently use the term 'on-board' for controllers.
 
 Minor line-wrapping improvements in descriptions for config options.
 
 Signed-off-by: Frans Pop [EMAIL PROTECTED]

applied, thanks
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] Use on-board instead of built-in in config options

2008-01-27 Thread Frans Pop
On Saturday 26 January 2008, Bartlomiej Zolnierkiewicz wrote:
> On Saturday 26 January 2008, Jan Engelhardt wrote:
> > On Jan 26 2008 21:31, Frans Pop wrote:
> > >>  config BLK_DEV_IDE_PMAC
> > >> -   bool "Builtin PowerMac IDE support"
> > >> +   tristate "Builtin PowerMac IDE support"
>
> this change is no-op at the moment because the next Kconfig line is:
>
>   depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
>
> [ PPC-specific IDE host drivers are still a special case because they are
>   using ppc_ide_md architecture hooks instead of doing proper host driver
>   initialization sequence - to be fixed after adding warm-plug support...
> ]
>
> > >This does not seem to make sense: if the option is now tristate, it is
> > > no longer "Builtin", so probably s/Builtin // in the description.
> >
> > Or something like s/Builtin/Onboard/;

I did not even consider that meaning of built-in, but that does seem more 
descriptive.

> Please send a patch.

Of course :-)

---
From: Frans Pop <[EMAIL PROTECTED]>

To avoid confusion between 'built-in' drivers and 'on-board'
controllers, consistently use the term 'on-board' for controllers.

Minor line-wrapping improvements in descriptions for config options.

Signed-off-by: Frans Pop <[EMAIL PROTECTED]>

---
Spelling for on-board seems to be rather inconsistent. All of "on board",
"on-board" and onboard currently occur. I've chosen "on-board" as that seems 
most correct to me.

diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 64df55e..92b0117 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -617,8 +617,8 @@ config BLK_DEV_SC1200
 	tristate "National SCx200 chipset support"
 	select BLK_DEV_IDEDMA_PCI
 	help
-	  This driver adds support for the built in IDE on the National
-	  SCx200 series of embedded x86 "Geode" systems
+	  This driver adds support for the on-board IDE controller on the
+	  National SCx200 series of embedded x86 "Geode" systems.
 
 config BLK_DEV_PIIX
 	tristate "Intel PIIXn chipsets support"
@@ -793,22 +793,22 @@ config BLK_DEV_CELLEB
 	depends on PPC_CELLEB
 	select BLK_DEV_IDEDMA_PCI
 	help
-	  This driver provides support for the built-in IDE controller on
+	  This driver provides support for the on-board IDE controller on
 	  Toshiba Cell Reference Board.
 	  If unsure, say Y.
 
 endif
 
 config BLK_DEV_IDE_PMAC
-	tristate "Builtin PowerMac IDE support"
+	tristate "PowerMac on-board IDE support"
 	depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
 	help
-	  This driver provides support for the built-in IDE controller on
+	  This driver provides support for the on-board IDE controller on
 	  most of the recent Apple Power Macintoshes and PowerBooks.
 	  If unsure, say Y.
 
 config BLK_DEV_IDE_PMAC_ATA100FIRST
-	bool "Probe internal ATA/100 (Kauai) first"
+	bool "Probe on-board ATA/100 (Kauai) first"
 	depends on BLK_DEV_IDE_PMAC
 	help
 	  This option will cause the ATA/100 controller found in UniNorth2
@@ -823,7 +823,7 @@ config BLK_DEV_IDEDMA_PMAC
 	depends on BLK_DEV_IDE_PMAC
 	select BLK_DEV_IDEDMA_PCI
 	help
-	  This option allows the driver for the built-in IDE controller on
+	  This option allows the driver for the on-board IDE controller on
 	  Power Macintoshes and PowerBooks to use DMA (direct memory access)
 	  to transfer data to and from memory.  Saying Y is safe and improves
 	  performance.
@@ -934,7 +934,7 @@ config BLK_DEV_GAYLE
 	help
 	  This is the IDE driver for the Amiga Gayle IDE interface. It supports
 	  both the `A1200 style' and `A4000 style' of the Gayle IDE interface,
-	  This includes builtin IDE interfaces on some Amiga models (A600,
+	  This includes on-board IDE interfaces on some Amiga models (A600,
 	  A1200, A4000, and A4000T), and IDE interfaces on the Zorro expansion
 	  bus (M-Tech E-Matrix 530 expansion card).
 	  Say Y if you have an Amiga with a Gayle IDE interface and want to use
@@ -948,10 +948,10 @@ config BLK_DEV_IDEDOUBLER
 	depends on BLK_DEV_GAYLE && EXPERIMENTAL
 	---help---
 	  This driver provides support for the so-called `IDE doublers' (made
-	  by various manufacturers, e.g. Eyetech) that can be connected to the
-	  builtin IDE interface of some Amiga models. Using such an IDE
-	  doubler, you can connect up to four instead of two IDE devices on
-	  the Amiga's builtin IDE interface.
+	  by various manufacturers, e.g. Eyetech) that can be connected to
+	  the on-board IDE interface of some Amiga models. Using such an IDE
+	  doubler, you can connect up to four instead of two IDE devices to
+	  the Amiga's on-board IDE interface.
 
 	  Note that the normal Amiga Gayle IDE driver may not work correctly
 	  if you have an IDE doubler and don't enable this driver!
@@ -963,9 +963,9 @@ config BLK_DEV_BUDDHA
 	tristate "Buddha/Catweasel/X-Surf IDE interface support (EXPERIMENTAL)"
 	depends on ZORRO && EXPERIMENTAL
 	help
-	  This is the IDE driver for the IDE interfaces on the Buddha, 
-	  Catweasel and X-Surf expansion boards.  It supports up to two interfaces 
-	  on