Re: [PATCH] Use pid_t instead of int
From: René Nyffenegger In include/linux/syscalls.h, the four functions sys_kill, sys_tgkill, sys_tkill and sys_rt_sigqueueinfo are declared with "int pid" and "int tgid". However, in kernel/signal.c, the corresponding definitions use the more appropriate "pid_t" (which is a typedef'd int). This patch changes "int" to "pid_t" in the declarations of sys_kill, sys_tgkill, sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h in order to harmonize the function declarations with their respective definitions. Signed-off-by: René Nyffenegger --- include/linux/syscalls.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index d795472..d507e75 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h @@ -371,10 +371,10 @@ asmlinkage long sys_rt_sigtimedwait(const sigset_t __user *uthese, size_t sigsetsize); asmlinkage long sys_rt_tgsigqueueinfo(pid_t tgid, pid_t pid, int sig, siginfo_t __user *uinfo); -asmlinkage long sys_kill(int pid, int sig); -asmlinkage long sys_tgkill(int tgid, int pid, int sig); -asmlinkage long sys_tkill(int pid, int sig); -asmlinkage long sys_rt_sigqueueinfo(int pid, int sig, siginfo_t __user *uinfo); +asmlinkage long sys_kill(pid_t pid, int sig); +asmlinkage long sys_tgkill(pid_t tgid, pid_t pid, int sig); +asmlinkage long sys_tkill(pid_t pid, int sig); +asmlinkage long sys_rt_sigqueueinfo(pid_t pid, int sig, siginfo_t __user *uinfo); asmlinkage long sys_sgetmask(void); asmlinkage long sys_ssetmask(int newmask); asmlinkage long sys_signal(int sig, __sighandler_t handler); -- 2.8.0
Re: [PATCH] Use pid_t instead of int
Somewhere else, pid_t is a typedef for an int. Rene On 09.05.2016 03:25, Andy Lutomirski wrote: > On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger > wrote: >> Use pid_t instead of int in the declarations of sys_kill, sys_tgkill, >> sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h > > The description is no good. *Why* are you changing it? > > I checked tgkill and, indeed, tgkill takes pid_t parameters, so this > fixes an incorrect declaration. I'm wondering why the code compiles > without warning. Is SYSCALL_DEFINE too lenient for some reason? Or > is pid_t just defined as int. > > --Andy >
Re: [PATCH] Use pid_t instead of int
On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger wrote: > Use pid_t instead of int in the declarations of sys_kill, sys_tgkill, > sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h The description is no good. *Why* are you changing it? I checked tgkill and, indeed, tgkill takes pid_t parameters, so this fixes an incorrect declaration. I'm wondering why the code compiles without warning. Is SYSCALL_DEFINE too lenient for some reason? Or is pid_t just defined as int. --Andy
[PATCH] Use pid_t instead of int
Use pid_t instead of int in the declarations of sys_kill, sys_tgkill, sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h Signed-off-by: René Nyffenegger --- include/linux/syscalls.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index d795472..d507e75 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h @@ -371,10 +371,10 @@ asmlinkage long sys_rt_sigtimedwait(const sigset_t __user *uthese, size_t sigsetsize); asmlinkage long sys_rt_tgsigqueueinfo(pid_t tgid, pid_t pid, int sig, siginfo_t __user *uinfo); -asmlinkage long sys_kill(int pid, int sig); -asmlinkage long sys_tgkill(int tgid, int pid, int sig); -asmlinkage long sys_tkill(int pid, int sig); -asmlinkage long sys_rt_sigqueueinfo(int pid, int sig, siginfo_t __user *uinfo); +asmlinkage long sys_kill(pid_t pid, int sig); +asmlinkage long sys_tgkill(int tgid, pid_t pid, int sig); +asmlinkage long sys_tkill(pid_t pid, int sig); +asmlinkage long sys_rt_sigqueueinfo(pid_t pid, int sig, siginfo_t __user *uinfo); asmlinkage long sys_sgetmask(void); asmlinkage long sys_ssetmask(int newmask); asmlinkage long sys_signal(int sig, __sighandler_t handler); -- 2.8.0